JavaScript: Include NPM error in marker details

Author: knutwannheden

rewrite-javascript/rewrite/src/javascript/package-manager.ts

@@ -533,9 +533,21 @@ export async function runInstallInTempDir(
         });
 
         if (!result.success) {
+            // Combine error message with stderr for more useful diagnostics
+            const errorParts: string[] = [];
+            if (result.error) {
+                errorParts.push(result.error);
+            }
+            if (result.stderr) {
+                // Trim and limit stderr to avoid excessively long error messages
+                const stderr = result.stderr.trim();
+                if (stderr) {
+                    errorParts.push(stderr.length > 2000 ? stderr.slice(0, 2000) + '...' : stderr);
+                }
+            }
             return {
                 success: false,
-                error: result.error || result.stderr || 'Unknown error'
+                error: errorParts.length > 0 ? errorParts.join('\n\n') : 'Unknown error'
             };
         }
 

rewrite-javascript/rewrite/src/print.ts

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import {Marker, MarkersKind, SearchResult} from "./markers";
+import {Marker, MarkersKind, Markup, SearchResult} from "./markers";
 import {Cursor, isSourceFile, SourceFile, Tree} from "./tree";
 import {TreeVisitor} from "./visitor";
 import {trimIndent} from "./util";
@@ -35,7 +35,11 @@ export namespace MarkerPrinter {
                 let searchResult = marker as SearchResult;
                 return commentWrapper(searchResult.description == null ? "" : "(" + searchResult.description + ")");
             } else if (marker.kind.startsWith("org.openrewrite.marker.Markup$")) {
-                return commentWrapper("(" + (marker as any).message + ")");
+                const markup = marker as Markup;
+                const content = markup.detail
+                    ? `(${markup.message}: ${markup.detail})`
+                    : `(${markup.message})`;
+                return commentWrapper(content);
             }
             return "";
         },