Commit 998e8c3
authored
Treat literal "null" string as null when reading marketplace CSV (#6826)
* Treat literal "null" string as null when reading marketplace CSV
RecipeMarketplaceReader already normalizes blank CSV values to null,
but does not handle the literal string "null". This can cause
RecipeBundle.version and requestedVersion to become the string "null"
after a CSV round-trip, leading to display artifacts like
"file:///path/to/file.yml:null" in mod config recipes list.
* Rely on univocity default null handling instead of manual isBlank check
Remove setNullValue("") so univocity returns null for empty fields
natively, eliminating the need for the redundant StringUtils.isBlank
check in the reading loop.
* Restore the blank handling1 parent 1f37320 commit 998e8c3
2 files changed
Lines changed: 39 additions & 1 deletion
File tree
- rewrite-core/src
- main/java/org/openrewrite/marketplace
- test/java/org/openrewrite/marketplace
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| |||
Lines changed: 38 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
350 | 350 | | |
351 | 351 | | |
352 | 352 | | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
353 | 391 | | |
354 | 392 | | |
355 | 393 | | |
| |||
0 commit comments