Skip to content

Commit 9e52e99

Browse files
Reorder maybeRemoveImport before maybeAddImport (#6439)
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.recipes.RemoveImportBeforeAddImport?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl Co-authored-by: Moderne <team@moderne.io>
1 parent eb23f4f commit 9e52e99

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

rewrite-java-test/src/test/java/org/openrewrite/java/JavaTemplateTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -444,8 +444,8 @@ void replaceAnonymousClassObject() {
444444
@Override
445445
public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
446446
if ("asList".equals(method.getSimpleName())) {
447-
maybeAddImport("java.util.Collections");
448447
maybeRemoveImport("java.util.Arrays");
448+
maybeAddImport("java.util.Collections");
449449

450450
return JavaTemplate.builder("Collections.singletonList(#{any()})")
451451
.imports("java.util.Collections")
@@ -492,8 +492,8 @@ void replaceGenericTypedObject() {
492492
@Override
493493
public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
494494
if ("asList".equals(method.getSimpleName())) {
495-
maybeAddImport("java.util.Collections");
496495
maybeRemoveImport("java.util.Arrays");
496+
maybeAddImport("java.util.Collections");
497497
return JavaTemplate.builder("Collections.singletonList(#{any()})")
498498
.imports("java.util.Collections")
499499
.build()
@@ -541,8 +541,8 @@ void replaceParameterizedTypeObject() {
541541
@Override
542542
public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
543543
if ("asList".equals(method.getSimpleName())) {
544-
maybeAddImport("java.util.Collections");
545544
maybeRemoveImport("java.util.Arrays");
545+
maybeAddImport("java.util.Collections");
546546
return JavaTemplate.builder("Collections.singletonList(#{any()})")
547547
.imports("java.util.Collections")
548548
.build()
@@ -1192,8 +1192,8 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
11921192
Expression expected = args.getFirst();
11931193
Expression actual = args.get(1);
11941194

1195-
maybeAddImport("org.assertj.core.api.Assertions", "assertThat");
11961195
maybeRemoveImport("org.junit.jupiter.api.Assertions");
1196+
maybeAddImport("org.assertj.core.api.Assertions", "assertThat");
11971197

11981198
if (args.size() == 2) {
11991199
return JavaTemplate.builder("assertThat(#{any()}).isEqualTo(#{any()});")

rewrite-java/src/main/java/org/openrewrite/java/ChangeFieldType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations m
4343
J.VariableDeclarations mv = super.visitVariableDeclarations(multiVariable, p);
4444
if (typeAsClass != null && oldFullyQualifiedTypeName.equals(typeAsClass.getFullyQualifiedName())) {
4545

46-
maybeAddImport(newFieldType);
4746
maybeRemoveImport(typeAsClass);
47+
maybeAddImport(newFieldType);
4848

4949
mv = mv.withTypeExpression(mv.getTypeExpression() == null ?
5050
null :

rewrite-java/src/main/java/org/openrewrite/java/ChangeMethodInvocationReturnType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations m
8787
JavaType newType = JavaType.buildType(newReturnType);
8888
JavaType.FullyQualified newFieldType = TypeUtils.asFullyQualified(newType);
8989

90-
maybeAddImport(newFieldType);
9190
maybeRemoveImport(originalType);
91+
maybeAddImport(newFieldType);
9292

9393
mv = mv.withTypeExpression(mv.getTypeExpression() == null ?
9494
null :

0 commit comments

Comments
 (0)