Commit aab13f2
committed
Do not auto-update exclusions when changing dependency coordinates
ChangeDependencyGroupIdAndArtifactId previously called ChangeExclusion to
rename all exclusions matching the old coordinates to the new ones. This is
incorrect because exclusions exist to block OLD transitive dependencies that
other libraries may still pull in. Changing the exclusion from the old to the
new coordinates means the old vulnerable artifact is no longer blocked.
A stale exclusion (excluding something no longer pulled in transitively) is
harmless, but an incorrect exclusion (no longer blocking a vulnerable
transitive dependency) causes real problems.1 parent 2825f94 commit aab13f2
2 files changed
Lines changed: 7 additions & 12 deletions
File tree
- rewrite-maven/src
- main/java/org/openrewrite/maven
- test/java/org/openrewrite/maven
Lines changed: 1 addition & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | | - | |
126 | | - | |
| 125 | + | |
127 | 126 | | |
128 | 127 | | |
129 | 128 | | |
| |||
270 | 269 | | |
271 | 270 | | |
272 | 271 | | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | 272 | | |
280 | 273 | | |
281 | 274 | | |
| |||
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3489 | 3489 | | |
3490 | 3490 | | |
3491 | 3491 | | |
3492 | | - | |
3493 | | - | |
3494 | | - | |
| 3492 | + | |
| 3493 | + | |
| 3494 | + | |
| 3495 | + | |
| 3496 | + | |
3495 | 3497 | | |
3496 | 3498 | | |
3497 | 3499 | | |
3498 | 3500 | | |
3499 | 3501 | | |
3500 | 3502 | | |
3501 | | - | |
| 3503 | + | |
3502 | 3504 | | |
3503 | 3505 | | |
3504 | 3506 | | |
| |||
0 commit comments