Do not pin managed versions from spring boot plugin (#6654)

* Do not pin managed versions from spring boot plugin when they are a property in the dependencyManagement

* require 1 less list

Author: Jenson3210

rewrite-gradle/src/main/java/org/openrewrite/gradle/plugins/UpgradePluginVersion.java

@@ -277,10 +277,10 @@ public Properties visitEntry(Properties.Entry entry, ExecutionContext ctx) {
                                             .filter(gav -> requested.stream().anyMatch(r -> r.equals(gav.asGroupArtifact())))
                                             .collect(toList());
 
+                                    List<GroupArtifact> newlyManaged = newPlatformManaged.stream().map(GroupArtifactVersion::asGroupArtifact).collect(toList());
                                     List<GroupArtifact> noLongerManaged = new ArrayList<>(oldPlatformManaged);
-                                    noLongerManaged.removeAll(newPlatformManaged);
+                                    noLongerManaged.removeAll(newlyManaged);
 
-                                    List<GroupArtifact> newlyManaged = newPlatformManaged.stream().map(GroupArtifactVersion::asGroupArtifact).collect(toList());
                                     newlyManaged.removeAll(oldPlatformManaged);
 
 

rewrite-gradle/src/test/java/org/openrewrite/gradle/plugins/UpgradePluginVersionTest.java

@@ -433,4 +433,44 @@ void springBootPluginsAreDependencyManagedVersionAware() {
           )
         );
     }
+
+    @Test
+    void doesNotPinPropertyManagedVersions() {
+        rewriteRun(
+          spec -> spec
+            .recipe(new UpgradePluginVersion("org.springframework.boot", "2.5.x", null)),
+          buildGradle(
+            """
+              plugins {
+                  id 'java'
+                  id 'org.springframework.boot' version '2.5.14'
+                  id 'io.spring.dependency-management' version '1.0.11.RELEASE'
+              }
+
+              repositories {
+                  mavenCentral()
+              }
+
+              dependencies {
+                  runtimeOnly 'mysql:mysql-connector-java'
+              }
+              """,
+            """
+              plugins {
+                  id 'java'
+                  id 'org.springframework.boot' version '2.5.15'
+                  id 'io.spring.dependency-management' version '1.0.11.RELEASE'
+              }
+
+              repositories {
+                  mavenCentral()
+              }
+
+              dependencies {
+                  runtimeOnly 'mysql:mysql-connector-java'
+              }
+              """
+          )
+        );
+    }
 }