Fix AddDependency bypassing onlyIfUsing with explicit config (#6834)

* Fix AddDependency bypassing onlyIfUsing check when configuration is explicit

When AddDependency is configured with both an explicit configuration (e.g., testRuntimeOnly) and onlyIfUsing (e.g., org.junit.jupiter.api.Test), the per-project type usage check is bypassed. This causes dependencies to be added to all build.gradle files, including buildSrc/build.gradle, rather than only projects that actually use the specified type.

Split the single guard condition into two separate checks: always check per-project type usage when onlyIfUsing is set, and only check configurationsByProject when configuration needs to be inferred. Add test to verify the fix.

Fixes #6833

* Pull up the second check on `onlyIfUsing` into the larger `if`

Author: timtebeek

rewrite-gradle/src/main/java/org/openrewrite/gradle/AddDependency.java

@@ -202,11 +202,13 @@ public TreeVisitor<?, ExecutionContext> getVisitor(Scanned acc) {
                         if (!maybeGp.isPresent()) {
                             return s;
                         }
-                        // When configuration needs to be inferred and onlyIfUsing is set, require JavaProject and source set info
-                        if (!hasExplicitConfiguration && onlyIfUsing != null) {
-                            if (!maybeJp.isPresent() ||
-                                    !acc.usingType.getOrDefault(maybeJp.get(), false) ||
-                                    !acc.configurationsByProject.containsKey(maybeJp.get())) {
+                        if (onlyIfUsing != null) {
+                            // When onlyIfUsing is set, skip projects that don't use the specified type
+                            if (!maybeJp.isPresent() || !acc.usingType.getOrDefault(maybeJp.get(), false)) {
+                                return s;
+                            }
+                            // When configuration needs to be inferred, also require source set info
+                            if (!hasExplicitConfiguration && !acc.configurationsByProject.containsKey(maybeJp.get())) {
                                 return s;
                             }
                         }

rewrite-gradle/src/test/java/org/openrewrite/gradle/AddDependencyTest.java

@@ -1161,6 +1161,76 @@ void addDependencyToProjectsThatNeedIt() {
         );
     }
 
+    @Test
+    @Issue("https://github.com/openrewrite/rewrite/issues/6833")
+    void doesNotAddToProjectNotUsingTypeWhenConfigurationIsExplicit() {
+        rewriteRun(
+          spec -> spec.recipe(addDependency("com.google.guava:guava:29.0-jre", "com.google.common.math.IntMath", "implementation")),
+          mavenProject("root",
+            buildGradle(
+              ""
+            ),
+            settingsGradle(
+              """
+                include "project1"
+                include "project2"
+                """
+            ),
+            mavenProject("project1",
+              srcMainJava(
+                java(usingGuavaIntMath)
+              ),
+              buildGradle(
+                """
+                  plugins {
+                      id 'java-library'
+                  }
+
+                  repositories {
+                      mavenCentral()
+                  }
+                  """,
+                """
+                  plugins {
+                      id 'java-library'
+                  }
+
+                  repositories {
+                      mavenCentral()
+                  }
+
+                  dependencies {
+                      implementation "com.google.guava:guava:29.0-jre"
+                  }
+                  """
+              )
+            ),
+            mavenProject("project2",
+              srcMainJava(
+                java(
+                  """
+                    public class B {
+                        String hello() { return "world"; }
+                    }
+                    """
+                )
+              ),
+              buildGradle(
+                """
+                  plugins {
+                      id 'java-library'
+                  }
+
+                  repositories {
+                      mavenCentral()
+                  }
+                  """
+              )
+            )
+          )
+        );
+    }
+
     @Test
     void addDynamicVersionDependency() {
         rewriteRun(