Groovy: fix parsing of inner constructor calls

Author: greg-at-moderne

rewrite-groovy/src/main/java/org/openrewrite/groovy/GroovyParserVisitor.java

@@ -2516,6 +2516,11 @@ public void visitTupleExpression(TupleExpression tuple) {
 
             List<JRightPadded<Expression>> args = new ArrayList<>(tuple.getExpressions().size());
             for (org.codehaus.groovy.ast.expr.Expression expression : tuple.getExpressions()) {
+                // Skip synthetic args (e.g. the implicit outer-`this` Groovy adds when
+                // constructing a non-static inner class from within the enclosing class)
+                if (!appearsInSource(expression)) {
+                    continue;
+                }
                 NamedArgumentListExpression namedArgList = (NamedArgumentListExpression) expression;
                 List<MapEntryExpression> mapEntryExpressions = namedArgList.getMapEntryExpressions();
                 for (int i = 0; i < mapEntryExpressions.size(); i++) {

rewrite-groovy/src/test/java/org/openrewrite/groovy/tree/ConstructorTest.java

@@ -151,6 +151,20 @@ class T {
         );
     }
 
+    @Test
+    void nonStaticInnerClassNamedArgs() {
+        rewriteRun(
+          groovy(
+            """
+              class T {
+                  class Reader { }
+                  def m() { new Reader(a: 1) }
+              }
+              """
+          )
+        );
+    }
+
     @Test
     void innerClassConstructorWithOnlySuperCall() {
         rewriteRun(