Skip to content

Commit e07aadb

Browse files
timtebeekTeamModerne
authored andcommitted
Replace getTags() method with field
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.recipes.UseTagsField?organizationId=QUxML01vZGVybmUvTW9kZXJuZSArIE9wZW5SZXdyaXRl Co-authored-by: Moderne <team@moderne.io>
1 parent 7bf9bc9 commit e07aadb

14 files changed

Lines changed: 23 additions & 55 deletions

File tree

rewrite-core/src/main/java/org/openrewrite/Recipe.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,8 @@ public String getInstanceNameSuffix() {
206206
*
207207
* @return The tags.
208208
*/
209-
public Set<String> getTags() {
210-
return emptySet();
211-
}
209+
@Getter
210+
final Set<String> tags = emptySet();
212211

213212
/**
214213
* @return An estimated effort were a developer to fix manually instead of using this recipe.

rewrite-core/src/main/java/org/openrewrite/rpc/RpcRecipe.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.openrewrite.rpc;
1717

18+
import lombok.Getter;
1819
import lombok.RequiredArgsConstructor;
1920
import org.jspecify.annotations.Nullable;
2021
import org.openrewrite.*;
@@ -63,10 +64,8 @@ public String getDescription() {
6364
return descriptor.getDescription();
6465
}
6566

66-
@Override
67-
public Set<String> getTags() {
68-
return descriptor.getTags();
69-
}
67+
@Getter
68+
final Set<String> tags = descriptor.getTags();
7069

7170
@Override
7271
public @Nullable Duration getEstimatedEffortPerOccurrence() {

rewrite-core/src/main/java/org/openrewrite/text/ChangeText.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ public class ChangeText extends Recipe {
3636
example = "Some text.")
3737
String toText;
3838

39-
@Override
40-
public Set<String> getTags() {
41-
return singleton("plain text");
42-
}
39+
Set<String> tags = singleton("plain text");
4340

4441
String displayName = "Change text";
4542

rewrite-gradle/src/main/java/org/openrewrite/gradle/RemoveRedundantSecurityResolutionRules.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,7 @@ public class RemoveRedundantSecurityResolutionRules extends Recipe {
8282
"being managed by a platform/BOM to equal or newer versions. Only removes rules that have a security " +
8383
"advisory identifier (CVE or GHSA) in the `because` clause, unless a custom pattern is specified.";
8484

85-
@Override
86-
public Set<String> getTags() {
87-
return singleton("security");
88-
}
85+
Set<String> tags = singleton("security");
8986

9087
@Override
9188
public TreeVisitor<?, ExecutionContext> getVisitor() {

rewrite-gradle/src/main/java/org/openrewrite/gradle/security/UseHttpsForRepositories.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,8 @@ public class UseHttpsForRepositories extends Recipe {
4141
@Getter
4242
final String description = "Use HTTPS for repository URLs.";
4343

44-
@Override
45-
public Set<String> getTags() {
46-
return singleton("security");
47-
}
44+
@Getter
45+
final Set<String> tags = singleton("security");
4846

4947
@Override
5048
public Duration getEstimatedEffortPerOccurrence() {

rewrite-java/src/main/java/org/openrewrite/java/RemoveUnusedImports.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,7 @@ public class RemoveUnusedImports extends Recipe {
5050
String description = "Remove imports for types that are not referenced. As a precaution against incorrect changes no imports " +
5151
"will be removed from any source where unknown types are referenced.";
5252

53-
@Override
54-
public Set<String> getTags() {
55-
return singleton("RSPEC-S1128");
56-
}
53+
Set<String> tags = singleton("RSPEC-S1128");
5754

5855
@Override
5956
public Duration getEstimatedEffortPerOccurrence() {

rewrite-java/src/main/java/org/openrewrite/java/format/EmptyNewlineAtEndOfFile.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,8 @@ public class EmptyNewlineAtEndOfFile extends Recipe {
4545
@Getter
4646
final String description = "Some tools work better when files end with an empty line.";
4747

48-
@Override
49-
public Set<String> getTags() {
50-
return singleton("RSPEC-S113");
51-
}
48+
@Getter
49+
final Set<String> tags = singleton("RSPEC-S113");
5250

5351
@Override
5452
public Duration getEstimatedEffortPerOccurrence() {

rewrite-java/src/main/java/org/openrewrite/java/format/WrappingAndBraces.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@ public class WrappingAndBraces extends Recipe {
3636
@Getter
3737
final String description = "Format line wraps and braces in Java code.";
3838

39-
@Override
40-
public Set<String> getTags() {
41-
return new LinkedHashSet<>(Arrays.asList("RSPEC-S121", "RSPEC-S2681", "RSPEC-S3972", "RSPEC-S3973"));
42-
}
39+
@Getter
40+
final Set<String> tags = new LinkedHashSet<>(Arrays.asList("RSPEC-S121", "RSPEC-S2681", "RSPEC-S3972", "RSPEC-S3973"));
4341

4442
@Override
4543
public Duration getEstimatedEffortPerOccurrence() {

rewrite-java/src/main/java/org/openrewrite/java/search/FindEmptyClasses.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,8 @@ public class FindEmptyClasses extends Recipe {
3737
@Getter
3838
final String description = "Find empty classes without annotations that do not implement an interface or extend a class.";
3939

40-
@Override
41-
public Set<String> getTags() {
42-
return singleton("RSPEC-S2094");
43-
}
40+
@Getter
41+
final Set<String> tags = singleton("RSPEC-S2094");
4442

4543
@Override
4644
public Duration getEstimatedEffortPerOccurrence() {

rewrite-java/src/main/java/org/openrewrite/java/search/FindEmptyMethods.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,7 @@ public class FindEmptyMethods extends Recipe {
4949

5050
String description = "Find methods with empty bodies and single public no arg constructors.";
5151

52-
@Override
53-
public Set<String> getTags() {
54-
return singleton("RSPEC-S1186");
55-
}
52+
Set<String> tags = singleton("RSPEC-S1186");
5653

5754
@Override
5855
public TreeVisitor<?, ExecutionContext> getVisitor() {

0 commit comments

Comments
 (0)