Allow Gradle AddDependency to work with explicit configuration without Java sources (#6624)

* Allow Gradle AddDependency to work with explicit configuration without Java sources

* Gradle AddDependency defaults to implementation when onlyIfUsing is null

When onlyIfUsing is not set and no explicit configuration is provided,
default to "implementation" configuration. This aligns with Maven's
AddDependency behavior which defaults to "compile" scope in the same
scenario.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: bmuschko

rewrite-gradle/src/main/java/org/openrewrite/gradle/AddDependency.java

@@ -184,7 +184,10 @@ private boolean usesType(SourceFile sourceFile, ExecutionContext ctx) {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor(Scanned acc) {
-        return Preconditions.check(!acc.configurationsByProject.isEmpty(),
+        // Allow when configuration is explicitly provided, when onlyIfUsing is not set (default to "implementation"),
+        // or when source files were scanned
+        boolean hasExplicitConfiguration = !StringUtils.isBlank(configuration);
+        return Preconditions.check(hasExplicitConfiguration || onlyIfUsing == null || !acc.configurationsByProject.isEmpty(),
                 Preconditions.check(new IsBuildGradle<>(), new JavaIsoVisitor<ExecutionContext>() {
 
                     @Override
@@ -195,27 +198,40 @@ public TreeVisitor<?, ExecutionContext> getVisitor(Scanned acc) {
                         JavaSourceFile s = (JavaSourceFile) tree;
                         Optional<JavaProject> maybeJp = s.getMarkers().findFirst(JavaProject.class);
                         Optional<GradleProject> maybeGp = s.getMarkers().findFirst(GradleProject.class);
-                        if (!maybeJp.isPresent() ||
-                                (onlyIfUsing != null && !acc.usingType.getOrDefault(maybeJp.get(), false)) || !acc.configurationsByProject.containsKey(maybeJp.get()) ||
-                                !maybeGp.isPresent()) {
+
+                        if (!maybeGp.isPresent()) {
                             return s;
                         }
+                        // When configuration needs to be inferred and onlyIfUsing is set, require JavaProject and source set info
+                        if (!hasExplicitConfiguration && onlyIfUsing != null) {
+                            if (!maybeJp.isPresent() ||
+                                    !acc.usingType.getOrDefault(maybeJp.get(), false) ||
+                                    !acc.configurationsByProject.containsKey(maybeJp.get())) {
+                                return s;
+                            }
+                        }
 
-                        JavaProject jp = maybeJp.get();
+                        JavaProject jp = maybeJp.orElse(null);
                         GradleProject gp = maybeGp.get();
 
-                        Set<String> resolvedConfigurations = StringUtils.isBlank(configuration) ?
-                                acc.configurationsByProject.getOrDefault(jp, new HashSet<>()) :
-                                new HashSet<>(singletonList(configuration));
+                        Set<String> resolvedConfigurations = hasExplicitConfiguration ?
+                                new HashSet<>(singletonList(configuration)) :
+                                acc.configurationsByProject.getOrDefault(jp, new HashSet<>());
                         if (resolvedConfigurations.isEmpty()) {
                             resolvedConfigurations.add("implementation");
                         }
 
-                        GradleConfigurationFilter gradleConfigurationFilter = new GradleConfigurationFilter(gp, resolvedConfigurations);
-                        gradleConfigurationFilter.removeTransitiveConfigurations();
-                        gradleConfigurationFilter.removeConfigurationsContainingDependency(new GroupArtifact(groupId, artifactId));
-                        gradleConfigurationFilter.removeConfigurationsContainingTransitiveDependency(new GroupArtifact(groupId, artifactId));
-                        resolvedConfigurations = gradleConfigurationFilter.getFilteredConfigurations();
+                        // Only apply filtering when the configuration is known to the GradleProject
+                        // (which requires Java sources to have been scanned with the tooling API)
+                        boolean configurationKnown = resolvedConfigurations.stream()
+                                .anyMatch(c -> gp.getConfiguration(c) != null);
+                        if (configurationKnown) {
+                            GradleConfigurationFilter gradleConfigurationFilter = new GradleConfigurationFilter(gp, resolvedConfigurations);
+                            gradleConfigurationFilter.removeTransitiveConfigurations();
+                            gradleConfigurationFilter.removeConfigurationsContainingDependency(new GroupArtifact(groupId, artifactId));
+                            gradleConfigurationFilter.removeConfigurationsContainingTransitiveDependency(new GroupArtifact(groupId, artifactId));
+                            resolvedConfigurations = gradleConfigurationFilter.getFilteredConfigurations();
+                        }
 
                         if (resolvedConfigurations.isEmpty()) {
                             return s;

rewrite-gradle/src/test/java/org/openrewrite/gradle/AddDependencyTest.java

@@ -1386,6 +1386,72 @@ void addUnconditionally() {
         );
     }
 
+    @Test
+    void addWithExplicitConfigurationAndNoJavaSources() {
+        rewriteRun(
+          spec -> spec.recipe(addDependency("com.google.guava:guava:29.0-jre", null, "implementation")),
+          mavenProject("project",
+            buildGradle(
+              """
+                plugins {
+                    id 'java'
+                }
+
+                repositories {
+                    mavenCentral()
+                }
+                """,
+              """
+                plugins {
+                    id 'java'
+                }
+
+                repositories {
+                    mavenCentral()
+                }
+
+                dependencies {
+                    implementation "com.google.guava:guava:29.0-jre"
+                }
+                """
+            )
+          )
+        );
+    }
+
+    @Test
+    void addWithNoTypeFilterAndNoJavaSourcesDefaultsToImplementation() {
+        rewriteRun(
+          spec -> spec.recipe(addDependency("com.google.guava:guava:29.0-jre", null, null)),
+          mavenProject("project",
+            buildGradle(
+              """
+                plugins {
+                    id 'java'
+                }
+
+                repositories {
+                    mavenCentral()
+                }
+                """,
+              """
+                plugins {
+                    id 'java'
+                }
+
+                repositories {
+                    mavenCentral()
+                }
+
+                dependencies {
+                    implementation "com.google.guava:guava:29.0-jre"
+                }
+                """
+            )
+          )
+        );
+    }
+
     @Issue("https://github.com/moderneinc/customer-requests/issues/792")
     @Nested
     class AddToJVMTestSuite {