Skip to content

Commit 05ae345

Browse files
committed
Rename wizard in functional tests
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
1 parent a270a94 commit 05ae345

File tree

7 files changed

+37
-37
lines changed

7 files changed

+37
-37
lines changed

src/plugins/vis_builder/server/plugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@ export class VisBuilderPlugin implements Plugin<VisBuilderPluginSetup, VisBuilde
3939
return {};
4040
}
4141

42-
public stop() { }
42+
public stop() {}
4343
}
Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,52 +7,52 @@ import expect from '@osd/expect';
77
import { FtrProviderContext } from '../../ftr_provider_context';
88

99
export default function ({ getService, getPageObjects }: FtrProviderContext) {
10-
const PageObjects = getPageObjects(['visualize', 'wizard', 'visChart']);
10+
const PageObjects = getPageObjects(['visualize', 'visBuilder', 'visChart']);
1111
const testSubjects = getService('testSubjects');
1212
const log = getService('log');
1313
const retry = getService('retry');
1414

15-
describe('Basic tests for wizard app ', function () {
15+
describe('Basic tests for visBuilder app ', function () {
1616
before(async () => {
17-
log.debug('navigateToApp wizard');
18-
await PageObjects.wizard.navigateToCreateWizard();
17+
log.debug('navigateToApp visBuilder');
18+
await PageObjects.visBuilder.navigateToCreateVisBuilder();
1919
});
2020

2121
it('should be able to switch data sources', async () => {
22-
const dataSourceValue = await PageObjects.wizard.selectDataSource(
23-
PageObjects.wizard.index.LOGSTASH_NON_TIME_BASED
22+
const dataSourceValue = await PageObjects.visBuilder.selectDataSource(
23+
PageObjects.visBuilder.index.LOGSTASH_NON_TIME_BASED
2424
);
2525

26-
expect(dataSourceValue).to.equal(PageObjects.wizard.index.LOGSTASH_NON_TIME_BASED);
26+
expect(dataSourceValue).to.equal(PageObjects.visBuilder.index.LOGSTASH_NON_TIME_BASED);
2727
// TODO: Switch with a datasource with unique fields to test if it exists
2828
});
2929

3030
it('should show visualization when a field is added', async () => {
3131
const expectedData = [2904, 2858, 2814, 2784, 1322];
32-
await PageObjects.wizard.addField('metric', 'Count');
33-
await PageObjects.wizard.addField('segment', 'Terms', 'machine.os.raw');
32+
await PageObjects.visBuilder.addField('metric', 'Count');
33+
await PageObjects.visBuilder.addField('segment', 'Terms', 'machine.os.raw');
3434

3535
const data = await PageObjects.visChart.getBarChartData();
3636
expect(data).to.eql(expectedData);
3737
});
3838

3939
it('should clear visualization when field is deleted', async () => {
40-
await PageObjects.wizard.removeField('metric', 0);
40+
await PageObjects.visBuilder.removeField('metric', 0);
4141

42-
const isEmptyWorkspace = await PageObjects.wizard.isEmptyWorkspace();
42+
const isEmptyWorkspace = await PageObjects.visBuilder.isEmptyWorkspace();
4343
expect(isEmptyWorkspace).to.be(true);
4444
});
4545

4646
it('should show warning before changing visualization type', async () => {
47-
await PageObjects.wizard.selectVisType('metric', false);
47+
await PageObjects.visBuilder.selectVisType('metric', false);
4848
const confirmModalExists = await testSubjects.exists('confirmVisChangeModal');
4949
expect(confirmModalExists).to.be(true);
5050

5151
await testSubjects.click('confirmModalCancelButton');
5252
});
5353

5454
it('should change visualization type', async () => {
55-
const pickerValue = await PageObjects.wizard.selectVisType('metric');
55+
const pickerValue = await PageObjects.visBuilder.selectVisType('metric');
5656

5757
expect(pickerValue).to.eql('Metric');
5858
});

test/functional/apps/wizard/_experimental_vis.ts renamed to test/functional/apps/vis_builder/_experimental_vis.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,25 @@ import { VISUALIZE_ENABLE_LABS_SETTING } from '../../../../src/plugins/visualiza
88
import { FtrProviderContext } from '../../ftr_provider_context';
99

1010
export default function ({ getService, getPageObjects }: FtrProviderContext) {
11-
const PageObjects = getPageObjects(['visualize', 'wizard']);
11+
const PageObjects = getPageObjects(['visualize', 'visBuilder']);
1212
const log = getService('log');
1313
const opensearchDashboardsServer = getService('opensearchDashboardsServer');
1414

15-
describe('experimental settings for wizard app ', function () {
16-
it('should show an notification when creating wizard visualization', async () => {
15+
describe('experimental settings for visBuilder app ', function () {
16+
it('should show an notification when creating visBuilder visualization', async () => {
1717
log.debug('navigateToApp visualize');
1818
await PageObjects.visualize.navigateToNewVisualization();
1919
await PageObjects.visualize.waitForVisualizationSelectPage();
2020

21-
// Try to find the wizard Vis type.
22-
const wizardVisTypeExists = await PageObjects.visualize.hasVisType('wizard');
21+
// Try to find the visBuilder Vis type.
22+
const wizardVisTypeExists = await PageObjects.visualize.hasVisType('visBuilder');
2323
expect(wizardVisTypeExists).to.be(true);
2424

2525
// Create a new visualization
26-
await PageObjects.visualize.clickVisType('wizard');
26+
await PageObjects.visualize.clickVisType('visBuilder');
2727

2828
// Check that the experimental banner is there and state that this is experimental
29-
const info = await PageObjects.wizard.getExperimentalInfo();
29+
const info = await PageObjects.visBuilder.getExperimentalInfo();
3030
expect(await info.getVisibleText()).to.contain('experimental');
3131
});
3232

@@ -38,9 +38,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
3838
await PageObjects.visualize.navigateToNewVisualization();
3939
await PageObjects.visualize.waitForVisualizationSelectPage();
4040

41-
// Try to find the wizard Vis type.
42-
const wizardVisTypeExists = await PageObjects.visualize.hasVisType('wizard');
43-
expect(wizardVisTypeExists).to.be(false);
41+
// Try to find the visBuilder Vis type.
42+
const visBuilderVisTypeExists = await PageObjects.visualize.hasVisType('visBuilder');
43+
expect(visBuilderVisTypeExists).to.be(false);
4444
});
4545

4646
after(async () => {
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
import { FtrProviderContext } from '../../ftr_provider_context.d';
6+
import { FtrProviderContext } from '../../ftr_provider_context';
77
import { UI_SETTINGS } from '../../../../src/plugins/data/common';
88

99
export default function ({ getService, loadTestFile }: FtrProviderContext) {
@@ -12,11 +12,11 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
1212
const opensearchArchiver = getService('opensearchArchiver');
1313
const opensearchDashboardsServer = getService('opensearchDashboardsServer');
1414

15-
describe('wizard app', function () {
15+
describe('visBuilder app', function () {
1616
this.tags('ciGroup13');
1717

1818
before(async function () {
19-
log.debug('Starting wizard before method');
19+
log.debug('Starting visBuilder before method');
2020
await browser.setWindowSize(1280, 800);
2121
await opensearchArchiver.loadIfNeeded('logstash_functional');
2222
await opensearchArchiver.loadIfNeeded('long_window_logstash');

test/functional/config.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export default async function ({ readConfigFile }) {
4848
require.resolve('./apps/status_page'),
4949
require.resolve('./apps/timeline'),
5050
require.resolve('./apps/visualize'),
51-
require.resolve('./apps/wizard'),
51+
require.resolve('./apps/vis_builder'),
5252
],
5353
pageObjects,
5454
services,
@@ -92,8 +92,8 @@ export default async function ({ readConfigFile }) {
9292
pathname: '/app/visualize',
9393
hash: '/',
9494
},
95-
wizard: {
96-
pathname: '/app/wizard',
95+
visBuilder: {
96+
pathname: '/app/vis_builder',
9797
hash: '/',
9898
},
9999
dashboard: {

test/functional/page_objects/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ import { TimePickerProvider } from './time_picker';
4444
import { TimelinePageProvider } from './timeline_page';
4545
import { VisualBuilderPageProvider } from './visual_builder_page';
4646
import { VisualizePageProvider } from './visualize_page';
47-
import { WizardPageProvider } from './wizard_page';
47+
import { VisBuilderPageProvider } from './vis_builder_page';
4848
import { VisualizeEditorPageProvider } from './visualize_editor_page';
4949
import { VisualizeChartPageProvider } from './visualize_chart_page';
5050
import { TileMapPageProvider } from './tile_map_page';
@@ -69,7 +69,7 @@ export const pageObjects = {
6969
timePicker: TimePickerProvider,
7070
visualBuilder: VisualBuilderPageProvider,
7171
visualize: VisualizePageProvider,
72-
wizard: WizardPageProvider,
72+
visBuilder: VisBuilderPageProvider,
7373
visEditor: VisualizeEditorPageProvider,
7474
visChart: VisualizeChartPageProvider,
7575
tileMap: TileMapPageProvider,

test/functional/page_objects/wizard_page.ts renamed to test/functional/page_objects/vis_builder_page.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import { FtrProviderContext } from '../ftr_provider_context';
77

8-
export function WizardPageProvider({ getService, getPageObjects }: FtrProviderContext) {
8+
export function VisBuilderPageProvider({ getService, getPageObjects }: FtrProviderContext) {
99
const testSubjects = getService('testSubjects');
1010
const find = getService('find');
1111
const browser = getService('browser');
@@ -16,14 +16,14 @@ export function WizardPageProvider({ getService, getPageObjects }: FtrProviderCo
1616
* This page object contains the visualization type selection, the landing page,
1717
* and the open/save dialog functions
1818
*/
19-
class WizardPage {
19+
class VisBuilderPage {
2020
index = {
2121
LOGSTASH_TIME_BASED: 'logstash-*',
2222
LOGSTASH_NON_TIME_BASED: 'logstash*',
2323
};
2424

25-
public async navigateToCreateWizard() {
26-
await common.navigateToApp('wizard');
25+
public async navigateToCreateVisBuilder() {
26+
await common.navigateToApp('visBuilder');
2727
await header.waitUntilLoadingHasFinished();
2828
}
2929

@@ -124,5 +124,5 @@ export function WizardPageProvider({ getService, getPageObjects }: FtrProviderCo
124124
}
125125
}
126126

127-
return new WizardPage();
127+
return new VisBuilderPage();
128128
}

0 commit comments

Comments
 (0)