Skip to content

Commit 55181d4

Browse files
[BUG] Fix missing y-axis for TSVB (#2079)
Issue: #1873 This was happening because of a prop useDefaultGroupDomain. This prop was introduced into the elastic charts to allow clustering for the multiple series which will share a common Y domain i.e for example the stacked and non- stacked bars will have the same Y common domain/axis. As per the elastic/charts whenever the useDefaultGroupDomain is set to true, it will force to group the series/visualiations groupId's to a default group domain. But, TSVB is not a shared Y domain. So the prop is unneeded. Further insight: From the code: ``` const groupId = hasSeparateAxis || isStackedWithinSeries ? seriesGroup.id : mainAxisGroupId; ``` where ``` const mainAxisGroupId = yAxisIdGenerator('main_group'); ``` ... which indicates that the global default `groupId` is not used by TSVB. Hence, TSVB should have not been using `useDefaultGroupDomain` ever. Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com>
1 parent 45324d3 commit 55181d4

File tree

1 file changed

+0
-1
lines changed
  • src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries

1 file changed

+0
-1
lines changed

src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/vis.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ export class TimeseriesVisualization extends Component {
212212
seriesDataRow.groupId = groupId;
213213
seriesDataRow.yScaleType = yScaleType;
214214
seriesDataRow.hideInLegend = Boolean(seriesGroup.hide_in_legend);
215-
seriesDataRow.useDefaultGroupDomain = !isCustomDomain;
216215
});
217216

218217
if (isCustomDomain) {

0 commit comments

Comments
 (0)