Skip to content

Commit e8b4899

Browse files
ashwin-pcjoshuarrrr
andcommitted
Github comment feedback
Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
1 parent 240cc1e commit e8b4899

File tree

4 files changed

+3
-3
lines changed

4 files changed

+3
-3
lines changed

src/plugins/wizard/public/application/_variables.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,3 @@
77

88
$osdHeaderOffset: $euiHeaderHeightCompensation;
99
$wizLeftNavWidth: 462px;
10-
$wizRightNavWidth: 320px;

src/plugins/wizard/public/application/components/right_nav.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export const RightNav = () => {
7979
<p>
8080
<FormattedMessage
8181
id="wizard.rightNav.changeVisType.modalDescription"
82-
defaultMessage="Currently, changing the visualization type clears the existing selection of fields. Are you sure you want to change the visualization type?"
82+
defaultMessage="Changing the visualization type will reset all field selections. Are you sure you want to continue?"
8383
/>
8484
</p>
8585
</EuiConfirmModal>

src/plugins/wizard/public/visualizations/common/expression_helpers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export const getAggExpressionFunctions = async (visualization: VisualizationStat
1616

1717
const indexPatternsService = getIndexPatterns();
1818
const indexPattern = await indexPatternsService.get(indexId);
19+
// aggConfigParams is the serealizeable aggConfigs that need to be reconstructed here using the agg servce
1920
const aggConfigs = getAggService().createAggConfigs(indexPattern, cloneDeep(aggConfigParams));
2021

2122
const opensearchDashboards = buildExpressionFunction<ExpressionFunctionOpenSearchDashboards>(

src/plugins/wizard/public/visualizations/vislib/histogram/histogram_vis_type.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const createHistogramConfig = (): VisualizationTypeOptions<HistogramOptio
3434
}),
3535
min: 1,
3636
max: 3,
37-
aggFilter: ['!geo_centroid', '!geo_bounds'], // '!geo_centroid', '!geo_bounds'
37+
aggFilter: ['!geo_centroid', '!geo_bounds'],
3838
defaults: { aggTypes: ['median'] },
3939
},
4040
{

0 commit comments

Comments
 (0)