Bump eslint-import-resolver-webpack and browserify-sign#5414
Merged
joshuarrrr merged 2 commits intoopensearch-project:mainfrom Nov 8, 2023
Merged
Bump eslint-import-resolver-webpack and browserify-sign#5414joshuarrrr merged 2 commits intoopensearch-project:mainfrom
eslint-import-resolver-webpack and browserify-sign#5414joshuarrrr merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #5414 +/- ##
==========================================
- Coverage 66.83% 66.81% -0.02%
==========================================
Files 3288 3288
Lines 63151 63151
Branches 10054 10054
==========================================
- Hits 42206 42196 -10
- Misses 18463 18478 +15
+ Partials 2482 2477 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
manasvinibs
approved these changes
Oct 31, 2023
ananzh
approved these changes
Nov 8, 2023
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-5414-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 088fc667c2ae480a007fbb0a76b96bbf9439f676
# Push it to GitHub
git push --set-upstream origin backport/backport-5414-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3Then, create a pull request where the |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5414-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 088fc667c2ae480a007fbb0a76b96bbf9439f676
# Push it to GitHub
git push --set-upstream origin backport/backport-5414-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Nov 8, 2023
Backport PR: opensearch-project#5414 Signed-off-by: ananzh <ananzh@amazon.com>
7 tasks
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Nov 8, 2023
Backport PR opensearch-project#5414 Signed-off-by: ananzh <ananzh@amazon.com>
7 tasks
ananzh
added a commit
that referenced
this pull request
Nov 10, 2023
Backport PR: #5414 Signed-off-by: ananzh <ananzh@amazon.com>
ananzh
added a commit
that referenced
this pull request
Nov 10, 2023
Backport PR #5414 Signed-off-by: ananzh <ananzh@amazon.com>
ananzh
pushed a commit
that referenced
this pull request
Dec 12, 2023
…#5483) Backport PR: #5414 Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit 90b0d02) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <miki@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eslint-import-resolver-webpackbump removes nested dep ofbrowserify-signbrowserify-sign, just updated yarn.lock to compatible fixed patch version.Issues Resolved
Fixes #5410
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration