Skip to content

Commit 6f66032

Browse files
committed
Fix issue with replacing number tokens in strings when toLocaleString is unavailable, such as when running tests (re: #8276)
1 parent e09af9a commit 6f66032

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

modules/core/localizer.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -289,13 +289,17 @@ export function coreLocalizer() {
289289
if (typeof result === 'string') {
290290
for (let key in replacements) {
291291
let value = replacements[key];
292-
if (typeof value === 'number' && value.toLocaleString) {
293-
// format numbers for the locale
294-
value = value.toLocaleString(locale, {
295-
style: 'decimal',
296-
useGrouping: true,
297-
minimumFractionDigits: 0
298-
});
292+
if (typeof value === 'number') {
293+
if (value.toLocaleString) {
294+
// format numbers for the locale
295+
value = value.toLocaleString(locale, {
296+
style: 'decimal',
297+
useGrouping: true,
298+
minimumFractionDigits: 0
299+
});
300+
} else {
301+
value = value.toString();
302+
}
299303
}
300304
const token = `{${key}}`;
301305
const regex = new RegExp(token, 'g');

0 commit comments

Comments
 (0)