make sure lngering event handlers aes cleared before setting new ones

fixes a bug where the valid options of multi/semi-combo fields were now updated properly when a previous tag change caused the preset of the feature to change.
for example: `leisure=pitch` with `sport=tennis`: when clearing the `sport` tag, the feature changes preset from "Tennis Court" to "Pitch", but it keeps the field for the `sport` tag. However, if the event handlers are not reset, the old event handlers (of the Tennis Cour preset) are still set, preventing the new ones (with the updated tag of the feature) from taking effect.
fixes #12217

Author: tyrasd

CHANGELOG.md

@@ -62,6 +62,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
 * Include `railway` and `building` features with lifecycle status only in _past/future_ features category ([#9058])
 * Disable autocomplete on changeset comment box on mobile Firefox to work around buggy/glitchy behavior of the input field ([#9011])
 * Fix crash when trying to delete a single-node way ([#9007])
+* Make sure the available options of multi/semi-combo fields are updated properly when a previous tag change caused a change of the feature's preset ([#12217])
 #### :earth_asia: Localization
 #### :hourglass: Performance
 #### :mortar_board: Walkthrough / Help
@@ -96,6 +97,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
 [#12139]: https://github.com/openstreetmap/iD/pull/12139
 [#12169]: https://github.com/openstreetmap/iD/issues/12169
 [#12178]: https://github.com/openstreetmap/iD/pull/12178
+[#12217]: https://github.com/openstreetmap/iD/issues/12217
 
 
 # 2.39.6

modules/ui/fields/combo.js

@@ -262,6 +262,9 @@ export function uiFieldCombo(field, context) {
             selection.attr('readonly', 'readonly');
         }
 
+        // clear previously existing old event handlers (e.g. when switching preset)
+        selection.call(uiCombobox.off, context);
+
         if (_showTagInfoSuggestions && services.taginfo) {
             selection.call(_combobox.fetcher(setTaginfoValues), attachTo);
             setTaginfoValues('', setPlaceholder);
@@ -703,9 +706,9 @@ export function uiFieldCombo(field, context) {
             .attr('type', 'text')
             .attr('dir', 'auto')
             .attr('id', field.domId)
+            .merge(_input)
             .call(utilNoAuto)
-            .call(initCombo, _container)
-            .merge(_input);
+            .call(initCombo, _container);
 
         if (_isSemi) {
             _inputWrap.call(_lengthIndicator);