[fix] Ensure POSIX shell compatibility in runtime scripts #572

Replace bash-specific syntax ([[ ]]) with POSIX-compliant ([ ]) to ensure compatibility with /bin/sh environments.

Fixes #572

Author: Piyushkhobragade

images/common/init_command.sh

@@ -29,7 +29,7 @@ elif [ "$MODULE_NAME" = 'freeradius' ]; then
 		source docker-entrypoint.sh -X
 	fi
 elif [ "$MODULE_NAME" = 'openvpn' ]; then
-	if [[ -z "$VPN_DOMAIN" ]]; then exit; fi
+	if [ -z "$VPN_DOMAIN" ]; then exit; fi
 	wait_nginx_services
 	openvpn_preconfig
 	openvpn_config
@@ -93,7 +93,7 @@ elif [ "$MODULE_NAME" = 'celery' ]; then
 			${OPENWISP_CELERY_NETWORK_COMMAND_FLAGS}
 	fi
 
-	if [[ "$USE_OPENWISP_FIRMWARE" == "True" && "$USE_OPENWISP_CELERY_FIRMWARE" == "True" ]]; then
+	if [ "$USE_OPENWISP_FIRMWARE" = "True" ] && [ "$USE_OPENWISP_CELERY_FIRMWARE" = "True" ]; then
 		echo "Starting the 'firmware_upgrader' celery worker"
 		celery -A openwisp worker -l ${DJANGO_LOG_LEVEL} --queues firmware_upgrader \
 			-n firmware_upgrader@%h --logfile /opt/openwisp/logs/celery_firmware_upgrader.log \
@@ -104,7 +104,7 @@ elif [ "$MODULE_NAME" = 'celery' ]; then
 	tail -f /opt/openwisp/logs/*
 elif [ "$MODULE_NAME" = 'celery_monitoring' ]; then
 	python services.py database redis dashboard
-	if [[ "$USE_OPENWISP_MONITORING" == "True" && "$USE_OPENWISP_CELERY_MONITORING" == 'True' ]]; then
+	if [ "$USE_OPENWISP_MONITORING" = "True" ] && [ "$USE_OPENWISP_CELERY_MONITORING" = "True" ]; then
 		echo "Starting the 'monitoring' celery worker"
 		celery -A openwisp worker -l ${DJANGO_LOG_LEVEL} --queues monitoring \
 			-n monitoring@%h --logfile /opt/openwisp/logs/celery_monitoring.log \

images/common/utils.sh

@@ -86,7 +86,7 @@ function wait_nginx_services {
 	set +e
 	while :; do
 		wget -qS ${DASHBOARD_INTERNAL}/admin/login/ 2>&1 | grep -q "200 OK"
-		if [[ $? = "0" ]]; then
+		if [ $? = "0" ]; then
 			FAILURE=0
 			echo "Connection with dashboard established."
 			break

images/openwisp_freeradius/Dockerfile

@@ -9,7 +9,7 @@ RUN apk add --no-cache --update \
 RUN addgroup -S freerad && \
     adduser -S freerad -G freerad
 
-CMD ["bash", "init_command.sh"]
+CMD ["sh", "init_command.sh"]
 EXPOSE 1812/udp 1813/udp
 
 # hadolint ignore=DL3045

images/openwisp_nfs/Dockerfile

@@ -15,4 +15,4 @@ ENV TZ=UTC \
     EXPORT_DIR="/exports" \
     EXPORT_OPTS="10.0.0.0/8(rw,fsid=0,insecure,no_root_squash,no_subtree_check,sync)"
 
-CMD ["bash", "init_command.sh"]
+CMD ["sh", "init_command.sh"]

images/openwisp_nginx/Dockerfile

@@ -9,7 +9,7 @@ RUN apk add --update --no-cache \
     rm -rf /var/cache/apk/* /tmp/*
 
 WORKDIR /etc/nginx/
-CMD ["bash", "init_command.sh"]
+CMD ["sh", "init_command.sh"]
 EXPOSE 80 443
 
 # DL3018

images/openwisp_openvpn/Dockerfile

@@ -7,7 +7,7 @@ RUN apk add --no-cache \
             tzdata \
             supervisor && \
     rm -rf /var/cache/apk/* /tmp/*
-CMD ["bash", "init_command.sh"]
+CMD ["sh", "init_command.sh"]
 EXPOSE 1194
 
 ENV MODULE_NAME=openvpn \

images/openwisp_postfix/Dockerfile

@@ -11,7 +11,7 @@ RUN apk add --no-cache --upgrade \
             tzdata && \
     rm -rf /tmp/* /var/cache/apk/*
 
-CMD ["bash", "init_command.sh"]
+CMD ["sh", "init_command.sh"]
 EXPOSE 25
 
 COPY ./openwisp_postfix/rsyslog.conf /etc/rsyslog.conf