[qa] Switched to double quotes (black formatter)

Author: nemesifier

openwisp_ipam/__init__.py

@@ -1,18 +1,18 @@
-VERSION = (1, 2, 0, 'alpha')
+VERSION = (1, 2, 0, "alpha")
 __version__ = VERSION  # alias
 
 
 def get_version():
-    version = '%s.%s' % (VERSION[0], VERSION[1])
+    version = "%s.%s" % (VERSION[0], VERSION[1])
     if VERSION[2]:
-        version = '%s.%s' % (version, VERSION[2])
-    if VERSION[3:] == ('alpha', 0):
-        version = '%s pre-alpha' % version
+        version = "%s.%s" % (version, VERSION[2])
+    if VERSION[3:] == ("alpha", 0):
+        version = "%s pre-alpha" % version
     else:
-        if VERSION[3] != 'final':
+        if VERSION[3] != "final":
             try:
                 rev = VERSION[4]
             except IndexError:
                 rev = 0
-            version = '%s%s%s' % (version, VERSION[3][0:1], rev)
+            version = "%s%s%s" % (version, VERSION[3][0:1], rev)
     return version

openwisp_ipam/admin.py

@@ -24,8 +24,8 @@
 from .base.models import CsvImportException
 from .filters import SubnetFilter, SubnetOrganizationFilter
 
-Subnet = swapper.load_model('openwisp_ipam', 'Subnet')
-IpAddress = swapper.load_model('openwisp_ipam', 'IpAddress')
+Subnet = swapper.load_model("openwisp_ipam", "Subnet")
+IpAddress = swapper.load_model("openwisp_ipam", "IpAddress")
 
 
 @admin.register(Subnet)
@@ -36,24 +36,24 @@ class SubnetAdmin(
     ModelAdmin,
     AuthorizeCSVOrgManaged,
 ):
-    app_label = 'openwisp_ipam'
-    change_form_template = 'admin/openwisp-ipam/subnet/change_form.html'
-    change_list_template = 'admin/openwisp-ipam/subnet/change_list.html'
+    app_label = "openwisp_ipam"
+    change_form_template = "admin/openwisp-ipam/subnet/change_form.html"
+    change_list_template = "admin/openwisp-ipam/subnet/change_list.html"
     list_display = [
-        'name',
-        'organization',
-        'subnet',
-        'master_subnet',
-        'created',
-        'modified',
+        "name",
+        "organization",
+        "subnet",
+        "master_subnet",
+        "created",
+        "modified",
     ]
     list_filter = [MultitenantOrgFilter]
-    autocomplete_fields = ['master_subnet']
-    search_fields = ['subnet', 'name']
-    list_select_related = ['organization', 'master_subnet']
+    autocomplete_fields = ["master_subnet"]
+    search_fields = ["subnet", "name"]
+    list_select_related = ["organization", "master_subnet"]
     save_on_top = True
 
-    def change_view(self, request, object_id, form_url='', extra_context=None):
+    def change_view(self, request, object_id, form_url="", extra_context=None):
         instance = self.get_object(request, object_id)
         if instance is None:
             # This is an internal Django method that redirects the
@@ -62,10 +62,10 @@ def change_view(self, request, object_id, form_url='', extra_context=None):
             return self._get_obj_does_not_exist_redirect(
                 request, self.model._meta, object_id
             )
-        ipaddress_add_url = 'admin:{0}_ipaddress_add'.format(self.app_label)
-        ipaddress_change_url = 'admin:{0}_ipaddress_change'.format(self.app_label)
-        subnet_change_url = 'admin:{0}_subnet_change'.format(self.app_label)
-        if request.GET.get('_popup'):
+        ipaddress_add_url = "admin:{0}_ipaddress_add".format(self.app_label)
+        ipaddress_change_url = "admin:{0}_ipaddress_change".format(self.app_label)
+        subnet_change_url = "admin:{0}_subnet_change".format(self.app_label)
+        if request.GET.get("_popup"):
             return super().change_view(request, object_id, form_url, extra_context)
         # Find root master_subnet for subnet tree
         instance_root = instance
@@ -74,16 +74,16 @@ def change_view(self, request, object_id, form_url='', extra_context=None):
         # Get instances for all subnets for root master_subnet
         instance_subnets = Subnet.objects.filter(
             subnet=instance_root.subnet, organization=instance_root.organization
-        ).values('master_subnet', 'pk', 'name', 'subnet')
+        ).values("master_subnet", "pk", "name", "subnet")
         # Make subnet tree
         collection_depth = 0
         subnet_tree = [instance_subnets]
         while instance_subnets:
             instance_subnets = Subnet.objects.none()
             for slave_subnet in subnet_tree[collection_depth]:
                 instance_subnets = instance_subnets | Subnet.objects.filter(
-                    master_subnet=slave_subnet['pk']
-                ).values('master_subnet', 'pk', 'name', 'subnet')
+                    master_subnet=slave_subnet["pk"]
+                ).values("master_subnet", "pk", "name", "subnet")
             subnet_tree.append(instance_subnets)
             collection_depth += 1
 
@@ -92,37 +92,37 @@ def change_view(self, request, object_id, form_url='', extra_context=None):
         # Storing UUID corresponding to respective IP address in a dictionary
         ip_id_list = (
             IpAddress.objects.filter(subnet=instance)
-            .annotate(str_id=Cast('id', output_field=TextField()))
-            .values_list('ip_address', 'str_id')
+            .annotate(str_id=Cast("id", output_field=TextField()))
+            .values_list("ip_address", "str_id")
         )
 
         # Converting UUIdField to String and then modifying to convert back to uuid form
         ip_id_list = OrderedDict(ip_id_list)
         ip_uuid = {}
         for ip_addr, Ip in ip_id_list.items():
-            ip_uuid[ip_addr] = f'{Ip[0:8]}-{Ip[8:12]}-{Ip[12:16]}-{Ip[16:20]}-{Ip[20:]}'
+            ip_uuid[ip_addr] = f"{Ip[0:8]}-{Ip[8:12]}-{Ip[12:16]}-{Ip[16:20]}-{Ip[20:]}"
         available = HostsSet(instance).count() - used
-        labels = ['Used', 'Available']
+        labels = ["Used", "Available"]
         values = [used, available]
         extra_context = {
-            'labels': labels,
-            'values': values,
-            'original': instance,
-            'ip_uuid': ip_uuid,
-            'ipaddress_add_url': ipaddress_add_url,
-            'ipaddress_change_url': ipaddress_change_url,
-            'subnet_change_url': subnet_change_url,
-            'subnet_tree': subnet_tree,
+            "labels": labels,
+            "values": values,
+            "original": instance,
+            "ip_uuid": ip_uuid,
+            "ipaddress_add_url": ipaddress_add_url,
+            "ipaddress_change_url": ipaddress_change_url,
+            "subnet_change_url": subnet_change_url,
+            "subnet_tree": subnet_tree,
         }
         return super().change_view(request, object_id, form_url, extra_context)
 
     def _check_perm(self, view, perm):
         admin_site = self.admin_site
 
         def inner(request, *args, **kwargs):
-            if not request.user.has_perm(f'{self.app_label}.{perm}'):
+            if not request.user.has_perm(f"{self.app_label}.{perm}"):
                 return redirect(
-                    reverse('admin:index', current_app=admin_site.name),
+                    reverse("admin:index", current_app=admin_site.name),
                 )
             return view(request, *args, **kwargs)
 
@@ -132,82 +132,82 @@ def get_urls(self):
         urls = super().get_urls()
         custom_urls = [
             re_path(
-                r'^(?P<subnet_id>[^/]+)/export-subnet/',
-                self._check_perm(self.export_view, 'change_subnet'),
-                name='ipam_export_subnet',
+                r"^(?P<subnet_id>[^/]+)/export-subnet/",
+                self._check_perm(self.export_view, "change_subnet"),
+                name="ipam_export_subnet",
             ),
             path(
-                'import-subnet/',
-                self._check_perm(self.import_view, 'add_subnet'),
-                name='ipam_import_subnet',
+                "import-subnet/",
+                self._check_perm(self.import_view, "add_subnet"),
+                name="ipam_import_subnet",
             ),
         ]
         return custom_urls + urls
 
     def export_view(self, request, subnet_id):
-        response = HttpResponse(content_type='text/csv')
-        response['Content-Disposition'] = 'attachment; filename="ip_address.csv"'
+        response = HttpResponse(content_type="text/csv")
+        response["Content-Disposition"] = 'attachment; filename="ip_address.csv"'
         writer = csv.writer(response)
         Subnet().export_csv(subnet_id, writer)
         return response
 
     def import_view(self, request):
         form = IpAddressImportForm()
-        form_template = 'admin/openwisp-ipam/subnet/import.html'
-        subnet_list_url = f'admin:{self.app_label}_{Subnet._meta.model_name}_changelist'
+        form_template = "admin/openwisp-ipam/subnet/import.html"
+        subnet_list_url = f"admin:{self.app_label}_{Subnet._meta.model_name}_changelist"
         context = {
-            'form': form,
-            'subnet_list_url': subnet_list_url,
-            'has_permission': True,
+            "form": form,
+            "subnet_list_url": subnet_list_url,
+            "has_permission": True,
         }
-        if request.method == 'POST':
+        if request.method == "POST":
             form = IpAddressImportForm(request.POST, request.FILES)
-            context['form'] = form
+            context["form"] = form
             if form.is_valid():
-                file = request.FILES['csvfile']
+                file = request.FILES["csvfile"]
                 try:
                     self.assert_organization_permissions(request)
                 except (PermissionDenied, CsvImportAPIException) as e:
                     messages.error(request, str(e))
-                    return redirect(reverse(context['subnet_list_url']))
-                if not file.name.endswith(('.csv', '.xls', '.xlsx')):
-                    messages.error(request, _('File type not supported.'))
+                    return redirect(reverse(context["subnet_list_url"]))
+                if not file.name.endswith((".csv", ".xls", ".xlsx")):
+                    messages.error(request, _("File type not supported."))
                     return render(request, form_template, context)
                 try:
                     Subnet().import_csv(file)
                 except CsvImportException as e:
                     messages.error(request, str(e))
                     return render(request, form_template, context)
-                messages.success(request, _('Successfully imported data.'))
-                return redirect(reverse(context['subnet_list_url']))
+                messages.success(request, _("Successfully imported data."))
+                return redirect(reverse(context["subnet_list_url"]))
         return render(request, form_template, context)
 
     def get_csv_organization(self, request):
-        data = Subnet._get_csv_reader(self, deepcopy(request.FILES['csvfile']))
+        data = Subnet._get_csv_reader(self, deepcopy(request.FILES["csvfile"]))
         return Subnet._get_org(self, org_slug=list(data)[2][0].strip())
 
     class Media:
         js = (
-            'admin/js/jquery.init.js',
-            'admin/js/SelectBox.js',
-            'openwisp-ipam/js/subnet.js',
-            'openwisp-ipam/js/minified/jstree.min.js',
-            'openwisp-ipam/js/minified/plotly.min.js',
+            "admin/js/jquery.init.js",
+            "admin/js/SelectBox.js",
+            "openwisp-ipam/js/subnet.js",
+            "openwisp-ipam/js/minified/jstree.min.js",
+            "openwisp-ipam/js/minified/plotly.min.js",
         )
         css = {
-            'all': (
-                'openwisp-ipam/css/admin.css',
-                'openwisp-ipam/css/minified/jstree.min.css',
+            "all": (
+                "openwisp-ipam/css/admin.css",
+                "openwisp-ipam/css/minified/jstree.min.css",
             )
         }
 
 
 class IpAddressAdminForm(forms.ModelForm):
     class Meta:
         help_texts = {
-            'subnet': _(
-                'Select a subnet and the first available IP address '
-                'will be automatically suggested in the ip address field'
+            "subnet": _(
+                "Select a subnet and the first available IP address "
+                "will be automatically suggested in the ip address field"
             )
         }
 
@@ -217,34 +217,34 @@ class IpAddressAdmin(
     VersionAdmin, MultitenantAdminMixin, TimeReadonlyAdminMixin, ModelAdmin
 ):
     form = IpAddressAdminForm
-    change_form_template = 'admin/openwisp-ipam/ip_address/change_form.html'
-    list_display = ['ip_address', 'subnet', 'organization', 'created', 'modified']
+    change_form_template = "admin/openwisp-ipam/ip_address/change_form.html"
+    list_display = ["ip_address", "subnet", "organization", "created", "modified"]
     list_filter = [SubnetOrganizationFilter, SubnetFilter]
-    search_fields = ['ip_address']
-    autocomplete_fields = ['subnet']
-    multitenant_parent = 'subnet'
-    list_select_related = ['subnet', 'subnet__organization']
+    search_fields = ["ip_address"]
+    autocomplete_fields = ["subnet"]
+    multitenant_parent = "subnet"
+    list_select_related = ["subnet", "subnet__organization"]
     save_on_top = True
 
     class Media:
         js = (
-            'admin/js/jquery.init.js',
-            'openwisp-ipam/js/ip-request.js',
+            "admin/js/jquery.init.js",
+            "openwisp-ipam/js/ip-request.js",
         )
 
     def organization(self, obj):
         return obj.subnet.organization
 
-    organization.short_description = _('organization')
+    organization.short_description = _("organization")
 
     def get_extra_context(self):
-        url = reverse('ipam:get_next_available_ip', args=['0000'])
-        return {'get_next_available_ip_url': url}
+        url = reverse("ipam:get_next_available_ip", args=["0000"])
+        return {"get_next_available_ip_url": url}
 
-    def add_view(self, request, form_url='', extra_context=None):
+    def add_view(self, request, form_url="", extra_context=None):
         return super().add_view(request, form_url, self.get_extra_context())
 
-    def change_view(self, request, object_id, form_url='', extra_context=None):
+    def change_view(self, request, object_id, form_url="", extra_context=None):
         return super().change_view(
             request, object_id, form_url, self.get_extra_context()
         )
@@ -254,7 +254,7 @@ def response_add(self, request, *args, **kwargs):
         Custom reponse to dismiss an add form popup for IP address.
         """
         response = super().response_add(request, *args, **kwargs)
-        if request.POST.get('_popup'):
+        if request.POST.get("_popup"):
             return HttpResponse(
                 f"""
 <script type='text/javascript'>
@@ -269,7 +269,7 @@ def response_change(self, request, *args, **kwargs):
         Custom reponse to dismiss a change form popup for IP address.
         """
         response = super().response_change(request, *args, **kwargs)
-        if request.POST.get('_popup'):
+        if request.POST.get("_popup"):
             return HttpResponse(
                 """
 <script type='text/javascript'>

openwisp_ipam/api/serializers.py

@@ -3,29 +3,29 @@
 from rest_framework import serializers
 from swapper import load_model
 
-IpAddress = load_model('openwisp_ipam', 'IpAddress')
-Subnet = load_model('openwisp_ipam', 'Subnet')
+IpAddress = load_model("openwisp_ipam", "IpAddress")
+Subnet = load_model("openwisp_ipam", "Subnet")
 
 
 class IpRequestSerializer(ValidatedModelSerializer):
     class Meta:
         model = IpAddress
-        fields = ('subnet', 'description')
-        read_only_fields = ('created', 'modified')
+        fields = ("subnet", "description")
+        read_only_fields = ("created", "modified")
 
 
 class IpAddressSerializer(FilterSerializerByOrgManaged, ValidatedModelSerializer):
     class Meta:
         model = IpAddress
-        fields = '__all__'
-        read_only_fields = ('created', 'modified')
+        fields = "__all__"
+        read_only_fields = ("created", "modified")
 
 
 class SubnetSerializer(FilterSerializerByOrgManaged, ValidatedModelSerializer):
     class Meta:
         model = Subnet
-        fields = '__all__'
-        read_only_fields = ('created', 'modified')
+        fields = "__all__"
+        read_only_fields = ("created", "modified")
 
 
 class ImportSubnetSerializer(serializers.Serializer):