[deps] Upgraded to Django 5.x and channels 4 #245

* [deps] Added "channels" and "channels-test" extra requires
* [deps] Added support for Django >=5.1,<5.3 and Python >=3.12, 3.14 #245

- Dropped support for Python < 3.9
- Dropped support for Django < 4.2

Closes #245

Author: pandafy

.github/workflows/ci.yml

@@ -24,13 +24,24 @@ jobs:
       fail-fast: false
       matrix:
         python-version:
-          - "3.8"
           - "3.9"
           - "3.10"
+          - "3.11"
+          - "3.12"
+          - "3.13"
         django-version:
-          - django~=3.2.0
-          - django~=4.1.0
           - django~=4.2.0
+          - django~=5.1.0
+          - django~=5.2.0
+        exclude:
+          # Django 5.1+ requires Python >=3.10
+          - python-version: "3.9"
+            django-version: django~=5.1.0
+          - python-version: "3.9"
+            django-version: django~=5.2.0
+          # Python 3.13 supported only in Django >=5.1.3
+          - python-version: "3.13"
+            django-version: django~=4.2.0
 
     steps:
       - uses: actions/checkout@v4

openwisp_network_topology/consumers.py

@@ -40,7 +40,6 @@ def connect(self):
 
     def disconnect(self, close_code):
         self.close()
-        pass
 
     def send_topology_update(self, event):
         self.send(

openwisp_network_topology/tests/test_websockets.py

@@ -59,12 +59,10 @@ async def _assert_connection_org_manager(self, client, view_perm=True, conn=True
         )
         t = await database_sync_to_async(self._create_topology)(organization=org)
         if view_perm:
-            topology_view_permission = await database_sync_to_async(
-                Permission.objects.get
-            )(codename='view_topology')
-            await database_sync_to_async(test_user.user_permissions.add)(
-                topology_view_permission
+            topology_view_permission = await Permission.objects.aget(
+                codename='view_topology'
             )
+            await test_user.user_permissions.aadd(topology_view_permission)
         await database_sync_to_async(client.force_login)(test_user)
         communicator = await self._get_communicator(client, t.pk)
         connected, _ = await communicator.connect()
@@ -134,7 +132,7 @@ async def test_node_topology_update(self, admin_user, admin_client):
         response = await communicator.receive_json_from()
         assert response['topology'] is not None
         assert response['topology'] == expected_response
-        await database_sync_to_async(node.delete)()
+        await node.adelete()
         expected_response = await database_sync_to_async(topo.json)()
         response = await communicator.receive_json_from()
         assert response['topology'] is not None
@@ -164,12 +162,12 @@ async def test_link_topology_update(self, admin_user, admin_client):
         assert response['topology'] == expected_response
         link.status = 'down'
         await database_sync_to_async(link.full_clean)()
-        await database_sync_to_async(link.save)()
+        await link.asave()
         expected_response = await database_sync_to_async(topo.json)()
         response = await communicator.receive_json_from()
         assert response['topology'] is not None
         assert response['topology'] == expected_response
-        await database_sync_to_async(link.delete)()
+        await link.adelete()
         expected_response = await database_sync_to_async(topo.json)()
         response = await communicator.receive_json_from()
         assert response['topology'] is not None
@@ -184,7 +182,7 @@ async def test_topology_properties_update(self, admin_user, admin_client):
         assert connected is True
         topo.name = 'test'
         await database_sync_to_async(topo.full_clean)()
-        await database_sync_to_async(topo.save)()
+        await topo.asave()
         expected_response = await database_sync_to_async(topo.json)()
         response = await communicator.receive_json_from()
         assert response['topology'] is not None

openwisp_network_topology/tests/utils.py

@@ -60,10 +60,10 @@ def _create_link(self, **kwargs):
 
 
 class LoggingDisabledTestRunner(TimeLoggingTestRunner):
-    def run_tests(self, test_labels, extra_tests=None, **kwargs):
+    def run_tests(self, test_labels, **kwargs):
         # disable logging below CRITICAL while testing
         logging.disable(logging.CRITICAL)
-        return super().run_tests(test_labels, extra_tests, **kwargs)
+        return super().run_tests(test_labels, **kwargs)
 
 
 class UnpublishMixin(object):

requirements-test.txt

@@ -1,10 +1,8 @@
 responses~=0.25.7
-pytest-asyncio~=0.24.0
-pytest-django~=4.10.0
 freezegun~=1.5.1
 # Needed to test integrations
 openwisp-monitoring @ https://github.com/openwisp/openwisp-monitoring/tarball/1.2
 openwisp-controller @ https://github.com/openwisp/openwisp-controller/tarball/1.2
-openwisp-utils[qa,selenium] @ https://github.com/openwisp/openwisp-utils/tarball/1.2
+openwisp-utils[qa,selenium,channels-test] @ https://github.com/openwisp/openwisp-utils/tarball/1.2
 redis~=5.2.1
 django_redis~=5.4.0

requirements.txt

@@ -2,4 +2,4 @@ openwisp-users @ https://github.com/openwisp/openwisp-users/tarball/1.2
 netdiff @ https://github.com/openwisp/netdiff/tarball/1.2
 jsonfield~=3.1.0
 django-flat-json-widget~=0.3.1
-openwisp-utils[celery] @ https://github.com/openwisp/openwisp-utils/tarball/1.2
+openwisp-utils[celery,channels] @ https://github.com/openwisp/openwisp-utils/tarball/1.2

tests/openwisp2/asgi.py

@@ -1,6 +1,7 @@
 from channels.auth import AuthMiddlewareStack
 from channels.routing import ProtocolTypeRouter, URLRouter
 from django.conf import settings
+from django.core.asgi import get_asgi_application
 
 if 'openwisp_controller.geo' in settings.INSTALLED_APPS:
     from openwisp_controller.routing import get_routes as get_controller_routes
@@ -27,5 +28,6 @@ def get_controller_routes():
                 + get_controller_routes()
             )
         ),
+        'http': get_asgi_application(),
     }
 )

tests/openwisp2/settings.py

@@ -20,6 +20,7 @@
 SECRET_KEY = '@q4z-^s=mv59#o=uutv4*m=h@)ik4%zp1)-k^_(!_7*x_&+ze$'
 
 INSTALLED_APPS = [
+    'daphne',
     'django.contrib.auth',
     'django.contrib.contenttypes',
     'django.contrib.sessions',