[fix] Requested changes by @coderabbitai

Author: pandafy

docs/user/rest-api.rst

@@ -980,6 +980,18 @@ Pagination is provided using page number pagination; default page size is
 
     GET /api/v1/users/user/<user_pk>/radius-group/
 
+It supports sorting by organization id and organization slug.
+
+Filters
+"""""""
+
+========================= ============================
+Filter Parameter          Description
+========================= ============================
+group__organization       Filter organizations by id
+group__organization__slug Filter organizations by slug
+========================= ============================
+
 POST
 ^^^^
 

openwisp_radius/api/serializers.py

@@ -373,8 +373,12 @@ class Meta:
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
-        view = self.context.get("view")
-        self._user = view.get_parent_queryset().first()
+        if self.context.get("view") and getattr(
+            self.context["view"], "get_parent_queryset", None
+        ):
+            self._user = self.context["view"].get_parent_queryset().first()
+        else:
+            self._user = None
         if self._user:
             self.fields["group"].queryset = self.fields["group"].queryset.filter(
                 organization_id__in=self._user.organizations_dict.keys()

openwisp_radius/api/views.py

@@ -983,6 +983,18 @@ def get_organization_queryset(self, qs):
         return qs.filter(**filter_kwargs).distinct()
 
 
+class RadiusUserGroupFilter(OrganizationManagedFilter, filters.FilterSet):
+    """
+    Filter RADIUS groups by organizations managed by the user.
+    """
+
+    organization_slug = None
+
+    class Meta(OrganizationManagedFilter.Meta):
+        model = RadiusUserGroup
+        fields = ["group__organization", "group__organization__slug"]
+
+
 @method_decorator(
     name="get",
     decorator=swagger_auto_schema(
@@ -1001,6 +1013,8 @@ def get_organization_queryset(self, qs):
 )
 class RadiusUserGroupListCreateView(BaseRadiusUserGroupView, ListCreateAPIView):
     pagination_class = RadiusGroupPaginator
+    filter_backends = [DjangoFilterBackend]
+    filterset_class = RadiusUserGroupFilter
 
 
 radius_user_group_list = RadiusUserGroupListCreateView.as_view()

openwisp_radius/tests/test_api/test_api.py

@@ -1331,6 +1331,16 @@ def test_radius_user_group_list(self):
             self.assertEqual(data["count"], 1)
             self.assertEqual(data["results"][0]["id"], str(rug.pk))
 
+        with self.subTest("Filter by organization query parameter"):
+            # requesting the same organization that the existing group belongs to
+            response = self.client.get(url + f"?group__organization={org1.pk}")
+            self.assertEqual(response.status_code, status.HTTP_200_OK)
+            self.assertEqual(response.data["count"], 1)
+            # a different organization should yield no results
+            response = self.client.get(url + f"?group__organization={org2.pk}")
+            self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+            self.assertIn("group__organization", response.data)
+
         with self.subTest("Create RadiusUserGroup"):
             org1_power_users = RadiusGroup.objects.get(
                 organization=org1, name="org-1-power-users"