[fix] Fixes by @coderabbitai

Author: pandafy

openwisp_users/management/commands/export_users.py

@@ -2,7 +2,7 @@
 
 from django.contrib.auth import get_user_model
 from django.core.exceptions import ObjectDoesNotExist
-from django.core.management.base import BaseCommand
+from django.core.management.base import BaseCommand, CommandError
 
 from ... import settings as app_settings
 
@@ -53,7 +53,9 @@ def add_arguments(self, parser):
     def handle(self, *args, **options):
         fields = app_settings.EXPORT_USERS_COMMAND_CONFIG.get("fields", []).copy()
         # Get the fields to be excluded from the command-line argument
-        exclude_fields = options.get("exclude_fields").split(",")
+        exclude_fields = [
+            t.strip() for t in options.get("exclude_fields").split(",") if t.strip()
+        ]
         # Remove excluded fields from the export fields (match on the field name)
         fields = [
             field
@@ -97,7 +99,7 @@ def _get_field_value(self, user, field):
             try:
                 return callable_fn(user)
             except Exception as e:
-                raise Exception(f"Error calling function for field '{name}': {e}")
+                raise CommandError(f"Error calling function for field '{name}': {e}")
         if subfields is not None:
             try:
                 attr = getattr(user, name)

openwisp_users/tests/test_commands.py

@@ -15,8 +15,6 @@
 
 
 class TestManagementCommands(TestOrganizationMixin, TestCase):
-    app_label = "openwisp_users"
-
     def setUp(self):
         super().setUp()
         self.temp_file = NamedTemporaryFile(mode="wt", delete=False)
@@ -126,6 +124,7 @@ def test_related_fields(self):
             "prefetch_related": [],
         },
     )
+    @capture_stdout()
     def test_related_fields_no_n_plus_1(self):
         """Query count must not grow with additional users."""
         user1 = self._create_user()
@@ -173,12 +172,12 @@ def _broken_callable(user):
                 {"name": "birth_date", "fields": ["year"]},
                 # manager with single subfield
                 {
-                    "name": f"{app_label}_organizationuser",
+                    "name": "openwisp_users_organizationuser",
                     "fields": ["organization_id"],
                 },
                 # manager with multiple subfields
                 {
-                    "name": f"{app_label}_organizationuser",
+                    "name": "openwisp_users_organizationuser",
                     "fields": ["organization_id", "is_admin"],
                 },
                 # dot-notation on a manager
@@ -188,6 +187,7 @@ def _broken_callable(user):
             "prefetch_related": ["openwisp_users_organizationuser"],
         },
     )
+    @capture_stdout()
     def test_subfields_dict_field(self):
         org = self._create_org(name="org1")
         user1 = self._create_user(birth_date=None)