Skip to content

Commit a85b3c5

Browse files
Fix workflow tags filter syntax (#1468)
tags: '' is not valid YAML for GitHub Actions. Use tags-ignore instead. Signed-off-by: Adrian Cole <adrian@tetrate.io>
1 parent 2eb77a1 commit a85b3c5

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/deploy.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,10 @@ name: deploy
88
# See https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
99
on:
1010
push:
11-
# Don't deploy tags as they conflict with [maven-release-plugin] prepare release MAJOR.MINOR.PATCH
12-
tags: ''
11+
# Don't deploy tags because the same commit for MAJOR.MINOR.PATCH is also
12+
# on master: Redundant deployment of a release version will fail uploading.
13+
tags-ignore:
14+
- '*'
1315
branches: master
1416

1517
jobs:

.github/workflows/test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ name: test
66
on:
77
# We run tests on non-tagged pushes to master that aren't a commit made by the release plugin
88
push:
9-
tags: ''
9+
tags-ignore:
10+
- '*'
1011
branches: master
1112
paths-ignore: '**/*.md'
1213
# We also run tests on pull requests targeted at the master branch.

0 commit comments

Comments
 (0)