Allows invoker tests to work with verify instead of install (#1471)

Sets invoker.install.scope=test so brave-tests resolves from the reactor
into the invoker local repo. Also sets updatePolicy=always on
local.central since it is a file-based repo with zero overhead.

Signed-off-by: Adrian Cole <adrian@tetrate.io>

Author: codefromthecrypt

build-bin/test

@@ -4,9 +4,6 @@
 #
 # See [README.md] for an explanation of this and how CI should use it.
 
-# We use install, not verify, because maven-invoker-tests need brave-tests
-# installed into the local repository before it can run.
-#
 # We avoid -T1C because some plugins don't work in parallel and also ITs are
 # difficult to debug when failures are in parallel.
-./mvnw install -nsu "$@"
+./mvnw verify -nsu "$@"

pom.xml

@@ -154,6 +154,9 @@
     <maven-help-plugin.version>3.5.1</maven-help-plugin.version>
     <maven-install-plugin.version>3.1.4</maven-install-plugin.version>
     <maven-invoker-plugin.version>3.9.1</maven-invoker-plugin.version>
+    <!-- default is runtime, but test-scoped reactor deps like brave-tests
+         need to be in the invoker local repo for IT projects to resolve -->
+    <invoker.install.scope>test</invoker.install.scope>
     <maven-javadoc-plugin.version>3.12.0</maven-javadoc-plugin.version>
     <maven-jar-plugin.version>3.5.0</maven-jar-plugin.version>
     <maven-release-plugin.version>3.3.1</maven-release-plugin.version>

spring-beans/pom.xml

@@ -58,6 +58,12 @@
       <version>${project.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>${project.groupId}</groupId>
+      <artifactId>brave-tests</artifactId>
+      <version>${project.version}</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 
   <build>

src/it/settings.xml

@@ -18,9 +18,11 @@
           <url>@localRepositoryUrl@</url>
           <releases>
             <enabled>true</enabled>
+            <updatePolicy>always</updatePolicy>
           </releases>
           <snapshots>
             <enabled>true</enabled>
+            <updatePolicy>always</updatePolicy>
           </snapshots>
         </repository>
       </repositories>
@@ -30,9 +32,11 @@
           <url>@localRepositoryUrl@</url>
           <releases>
             <enabled>true</enabled>
+            <updatePolicy>always</updatePolicy>
           </releases>
           <snapshots>
             <enabled>true</enabled>
+            <updatePolicy>always</updatePolicy>
           </snapshots>
         </pluginRepository>
       </pluginRepositories>