Skip to content

Commit d224d38

Browse files
Remove outdated BOM warning from dependencyManagement (#1472)
flattenMode=ossrh strips dependencyManagement from published poms, so end users never inherit BOMs declared here. See: https://github.com/mojohaus/flatten-maven-plugin/blob/master/src/main/java/org/codehaus/mojo/flatten/FlattenMode.java Signed-off-by: Adrian Cole <adrian@tetrate.io> Signed-off-by: Adrian Cole <adrian@tetrate.io>
1 parent c754be0 commit d224d38

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -186,14 +186,6 @@
186186
<url>https://github.com/openzipkin/brave/issues</url>
187187
</issueManagement>
188188

189-
<dependencyManagement>
190-
<!-- Be careful here, especially to not import BOMs as io.zipkin.brave:brave has this parent.
191-
192-
For example, if you imported Netty's BOM here, using Brave would also download that BOM. As
193-
Brave is indirectly used, this can be extremely confusing when people are troubleshooting
194-
library version assignments. -->
195-
</dependencyManagement>
196-
197189
<dependencies>
198190
<!-- Do not add compile dependencies here. This can cause problems for libraries that depend on
199191
io.zipkin.brave:brave difficult to unravel. -->

0 commit comments

Comments
 (0)