Require review from specific team setting specifics?

[bui-andrew]

🏷️ Discussion Type

Question

Body

Hi, I'm looking to get some clarity on the Require review from specific team setting on branch rulesets. Previous to this feature, we wanted to add a member from senior-eng-team to be a required reviewer, without notifying everyone in the group (large 60+ group). We wanted the author to look through the group and pick an appropriate reviewer. We also wanted to use the merge queue.

To accomplish this, we had:

• a branch protection rule with senior-eng-team in the Restrict who can push to matching branches list.
• a ruleset on the same branch merge queue enabled.

Together, those two settings made it so that for any PR targeting that branch, only a member of senior-eng-team can see the 'Merge when ready' button. It didn't necessarily require a review, but it would implicitly, since the author needed to find a senior-eng-team member to click 'Merge when ready'.

I found this setting Require review from specific team that seems to be able to better accomplish what I'm looking for, with caveat, but would like to confirm my understanding. If I use just the ruleset with merge queue enabled, and Require review from specific team set up with senior-eng-team for * files, I see that on the PR:

• the 'Merge when ready' button is available for all users
• the PR does still add the senior-eng-team to the list of required reviewers (like how CODEOWNERS does it), therefore making it unclear on the author who to select
• the PR merge box has a message about Merging is blocked:

Is there a way to enforce a review from a senior-eng-team member without adding the team slug to the list of reviewers?

[HalfBlanket]

No, GitHub currently requires the team to appear as reviewers if you enforce a team based review rule. So it cant be hidden