Merge pull request #43 from osorensen/no-user-updates

osorensen · web-flow · commit 55d253047251 · 2026-01-15T15:10:42.000+01:00
fix: prevent users from entering at multiple timepoints across all da…
diff --git a/R/compute_sequentially.R b/R/compute_sequentially.R
@@ -72,9 +72,12 @@ compute_sequentially <- function(
     stop("Something wrong with data")
   }
 
-  if(max(table(data$user)) > 1 &&
-     attr(input_timeseries, "type") != "pairwise preferences") {
-    stop("Updated users not supported.")
+  # Check that each user appears at most once across all timepoints
+  user_timepoint_combinations <- unique(data[c("user", "timepoint")])
+  if(max(table(user_timepoint_combinations$user)) > 1) {
+    stop("Each user can only enter the pool once. Users appearing at multiple timepoints: ",
+         paste(names(table(user_timepoint_combinations$user))[table(user_timepoint_combinations$user) > 1], 
+               collapse = ", "))
   }
 
   ret <- run_smc(input_timeseries, hyperparameters, smc_options,

Original file line number	Diff line number	Diff line change
`@@ -72,9 +72,12 @@ compute_sequentially <- function(`
`72`	`72`	`stop("Something wrong with data")`
`73`	`73`	`}`
`74`	`74`
`75`		`- if(max(table(data$user)) > 1 &&`
`76`		`- attr(input_timeseries, "type") != "pairwise preferences") {`
`77`		`- stop("Updated users not supported.")`
	`75`	`+ # Check that each user appears at most once across all timepoints`
	`76`	`+ user_timepoint_combinations <- unique(data[c("user", "timepoint")])`
	`77`	`+ if(max(table(user_timepoint_combinations$user)) > 1) {`
	`78`	`+ stop("Each user can only enter the pool once. Users appearing at multiple timepoints: ",`
	`79`	`+ paste(names(table(user_timepoint_combinations$user))[table(user_timepoint_combinations$user) > 1],`
	`80`	`+ collapse = ", "))`
`78`	`81`	`}`
`79`	`82`
`80`	`83`	`ret <- run_smc(input_timeseries, hyperparameters, smc_options,`