fix: error when used with @eslint/json (#529)

ota-meshi · web-flow · commit 8f172bef026e · 2026-02-14T17:57:19.000+09:00
* fix: error when used with @eslint/json

* Create slow-phones-look.md

* Update slow-phones-look.md

* fix

* fix

* fix

* revert
diff --git a/.changeset/slow-phones-look.md b/.changeset/slow-phones-look.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-astro": patch
+---
+
+fix: error when used with `@eslint/json`
diff --git a/.github/workflows/NodeCI.yml b/.github/workflows/NodeCI.yml
@@ -54,6 +54,27 @@ jobs:
         run: npm test
       - name: Type Test
         run: npm run test:type
+  # test-for-eslint-v10:
+  #   runs-on: ubuntu-latest
+  #   strategy:
+  #     matrix:
+  #       node-version: [20.x, 22.x, 24.x]
+  #   steps:
+  #     - uses: actions/checkout@v6
+  #     - name: Use Node.js ${{ matrix.node-version }}
+  #       uses: actions/setup-node@v6
+  #       with:
+  #         node-version: ${{ matrix.node-version }}
+  #     - name: Install eslint v10
+  #       run: |+
+  #         npm i -D eslint@10 -f
+  #         npx rimraf node_modules
+  #     - name: Install Packages
+  #       run: npm install -f
+  #     - name: Test
+  #       run: npm test
+  #     - name: Type Test
+  #       run: npm run test:type
   test-for-eslint-v8:
     runs-on: ubuntu-latest
     steps:
diff --git a/package.json b/package.json
@@ -28,7 +28,9 @@
     "test:type": "tsc --noEmit",
     "cover": "nyc --reporter=lcov npm run test",
     "debug": "npm run mocha -- \"tests/src/**/*.ts\" --reporter dot --timeout 60000",
-    "lint": "eslint .",
+    "lint": "npm run lint:js && npm run lint:ts",
+    "lint:js": "eslint .",
+    "lint:ts": "tsc --noEmit",
     "eslint-fix": "eslint . --fix",
     "update": "npm run ts -- ./tools/update.ts",
     "new": "npm run ts -- ./tools/new-rule.ts",
@@ -85,6 +87,7 @@
     "@eslint-community/eslint-plugin-eslint-comments": "^4.3.0",
     "@eslint/eslintrc": "^3.0.0",
     "@eslint/js": "^9.0.0",
+    "@eslint/json": "^1.0.1",
     "@ota-meshi/eslint-plugin": "^0.18.0",
     "@types/eslint-scope": "^8.0.0",
     "@types/eslint-utils": "^3.0.1",
diff --git a/src/a11y/rules.ts b/src/a11y/rules.ts
@@ -96,7 +96,7 @@ function defineWrapperListener(
   context: RuleContext,
 ): RuleListener {
   const sourceCode = getSourceCode(context)
-  if (!sourceCode.parserServices.isAstro) {
+  if (!sourceCode.parserServices?.isAstro) {
     return {}
   }
   const listener = coreRule.create(context)
@@ -114,7 +114,7 @@ function defineWrapperListener(
       node: never,
       ...args: never[]
     ) {
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any, no-invalid-this -- ignore
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any -- ignore
       ;(original as any).call(this, getProxyNode(node), ...args)
     }
 
diff --git a/src/rules/missing-client-only-directive-value.ts b/src/rules/missing-client-only-directive-value.ts
@@ -21,7 +21,7 @@ export default createRule("missing-client-only-directive-value", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-conflict-set-directives.ts b/src/rules/no-conflict-set-directives.ts
@@ -20,7 +20,7 @@ export default createRule("no-conflict-set-directives", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-deprecated-astro-canonicalurl.ts b/src/rules/no-deprecated-astro-canonicalurl.ts
@@ -20,7 +20,7 @@ export default createRule("no-deprecated-astro-canonicalurl", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-deprecated-astro-fetchcontent.ts b/src/rules/no-deprecated-astro-fetchcontent.ts
@@ -21,7 +21,7 @@ export default createRule("no-deprecated-astro-fetchcontent", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-deprecated-astro-resolve.ts b/src/rules/no-deprecated-astro-resolve.ts
@@ -19,7 +19,7 @@ export default createRule("no-deprecated-astro-resolve", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-deprecated-getentrybyslug.ts b/src/rules/no-deprecated-getentrybyslug.ts
@@ -19,7 +19,7 @@ export default createRule("no-deprecated-getentrybyslug", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-exports-from-components.ts b/src/rules/no-exports-from-components.ts
@@ -22,7 +22,7 @@ export default createRule("no-exports-from-components", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-set-html-directive.ts b/src/rules/no-set-html-directive.ts
@@ -20,7 +20,7 @@ export default createRule("no-set-html-directive", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-set-text-directive.ts b/src/rules/no-set-text-directive.ts
@@ -21,7 +21,7 @@ export default createRule("no-set-text-directive", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-unsafe-inline-scripts.ts b/src/rules/no-unsafe-inline-scripts.ts
@@ -59,7 +59,7 @@ export default createRule("no-unsafe-inline-scripts", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/no-unused-css-selector.ts b/src/rules/no-unused-css-selector.ts
@@ -46,7 +46,7 @@ export default createRule("no-unused-css-selector", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
     const styles: AST.JSXElement[] = []
diff --git a/src/rules/no-unused-define-vars-in-style.ts b/src/rules/no-unused-define-vars-in-style.ts
@@ -24,7 +24,7 @@ export default createRule("no-unused-define-vars-in-style", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/prefer-class-list-directive.ts b/src/rules/prefer-class-list-directive.ts
@@ -23,7 +23,7 @@ export default createRule("prefer-class-list-directive", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/prefer-object-class-list.ts b/src/rules/prefer-object-class-list.ts
@@ -36,7 +36,7 @@ export default createRule("prefer-object-class-list", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/prefer-split-class-list.ts b/src/rules/prefer-split-class-list.ts
@@ -46,7 +46,7 @@ export default createRule("prefer-split-class-list", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/semi.ts b/src/rules/semi.ts
@@ -72,7 +72,7 @@ export default createRule("semi", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
     const OPT_OUT_PATTERN = /^[(+\-/[`]/u // One of [(/+-`
@@ -82,13 +82,13 @@ export default createRule("semi", {
     const never = context.options[0] === "never"
     const exceptOneLine = Boolean(
       options &&
-        "omitLastInOneLineBlock" in options &&
-        options.omitLastInOneLineBlock,
+      "omitLastInOneLineBlock" in options &&
+      options.omitLastInOneLineBlock,
     )
     const exceptOneLineClassBody = Boolean(
       options &&
-        "omitLastInOneLineClassBody" in options &&
-        options.omitLastInOneLineClassBody,
+      "omitLastInOneLineClassBody" in options &&
+      options.omitLastInOneLineClassBody,
     )
     const beforeStatementContinuationChars =
       (options &&
diff --git a/src/rules/sort-attributes.ts b/src/rules/sort-attributes.ts
@@ -32,7 +32,7 @@ export default createRule("sort-attributes", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
       return {}
     }
 
diff --git a/src/rules/valid-compile.ts b/src/rules/valid-compile.ts
@@ -16,10 +16,14 @@ export default createRule("valid-compile", {
   },
   create(context) {
     const sourceCode = getSourceCode(context)
-    if (!sourceCode.parserServices.isAstro) {
+    if (!sourceCode.parserServices?.isAstro) {
+      return {}
+    }
+    const diagnostics =
+      sourceCode.parserServices?.getAstroResult?.().diagnostics
+    if (!diagnostics) {
       return {}
     }
-    const diagnostics = sourceCode.parserServices.getAstroResult().diagnostics
 
     return {
       Program() {
diff --git a/src/types.ts b/src/types.ts
@@ -12,6 +12,7 @@ import type {
   ASTNodeWithParent,
   ASTNodeListener,
 } from "./types-for-node"
+import type { ParseResult } from "@astrojs/compiler"
 
 export type { ASTNode, ASTNodeWithParent, ASTNodeListener }
 export interface RuleListener extends ASTNodeListener {
@@ -200,7 +201,10 @@ export interface SourceCode {
   ast: AST.AstroProgram
   lines: string[]
   hasBOM: boolean
-  parserServices: ESLintSourceCode.ParserServices
+  parserServices?: {
+    isAstro?: boolean
+    getAstroResult?: () => ParseResult
+  }
   scopeManager: Scope.ScopeManager
   visitorKeys: ESLintSourceCode.VisitorKeys
 
diff --git a/tests/src/config/recommended.ts b/tests/src/config/recommended.ts
@@ -1,6 +1,8 @@
 import assert from "assert"
 import plugin from "../../../src/index.cts"
 import { LegacyESLint, FlatESLint } from "../../utils/eslint-compat"
+import { ESLint } from "eslint"
+import semver from "semver"
 
 const code = `---
 const foo = 42
@@ -13,7 +15,10 @@ const foo = 42
 </style>
 `
 describe("`recommended` config", () => {
-  it("legacy `recommended` config should work. ", async () => {
+  const itSkipWhenESLintV10 = semver.satisfies(ESLint.version, ">=10")
+    ? it.skip
+    : it
+  itSkipWhenESLintV10("legacy `recommended` config should work. ", async () => {
     const linter = new LegacyESLint({
       plugins: {
         astro: plugin as never,
diff --git a/tests/src/integration/compat-with-eslint-json.ts b/tests/src/integration/compat-with-eslint-json.ts
@@ -0,0 +1,45 @@
+import json from "@eslint/json"
+import { Linter } from "eslint"
+import { rules } from "../../../src/rules/index.ts"
+import assert from "assert"
+import { ESLint } from "eslint"
+import semver from "semver"
+
+const describeSkipWhenESLintV8 = semver.satisfies(ESLint.version, "<9")
+  ? describe.skip
+  : describe
+describeSkipWhenESLintV8("compat with @eslint/json", () => {
+  describe("should not throw error from astro rules when used with @eslint/json", () => {
+    for (const rule of rules) {
+      it(rule.meta.docs.ruleName, () => {
+        const code = `{
+          "key": "value"
+        }`
+        const linter = new Linter()
+
+        const messages = linter.verify(
+          code,
+          [
+            {
+              files: ["**/*.json", "*.json"],
+              plugins: {
+                json: json as any,
+                astro: {
+                  rules: {
+                    [rule.meta.docs.ruleName]: rule as any,
+                  },
+                },
+              },
+              language: "json/json",
+              rules: {
+                [rule.meta.docs.ruleId]: "error",
+              },
+            },
+          ],
+          "test.json",
+        )
+        assert.deepStrictEqual(messages, [])
+      })
+    }
+  })
+})

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"eslint-plugin-astro": patch
 +---
++
 +fix: error when used with `@eslint/json`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export default createRule("missing-client-only-directive-value", {`
`21`	`21`	`},`
`22`	`22`	`create(context) {`
`23`	`23`	`const sourceCode = getSourceCode(context)`
`24`		`- if (!sourceCode.parserServices.isAstro) {`
	`24`	`+ if (!sourceCode.parserServices?.isAstro) {`
`25`	`25`	`return {}`
`26`	`26`	`}`
`27`	`27`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export default createRule("no-conflict-set-directives", {`
`20`	`20`	`},`
`21`	`21`	`create(context) {`
`22`	`22`	`const sourceCode = getSourceCode(context)`
`23`		`- if (!sourceCode.parserServices.isAstro) {`
	`23`	`+ if (!sourceCode.parserServices?.isAstro) {`
`24`	`24`	`return {}`
`25`	`25`	`}`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ export default createRule("no-deprecated-astro-resolve", {`
`19`	`19`	`},`
`20`	`20`	`create(context) {`
`21`	`21`	`const sourceCode = getSourceCode(context)`
`22`		`- if (!sourceCode.parserServices.isAstro) {`
	`22`	`+ if (!sourceCode.parserServices?.isAstro) {`
`23`	`23`	`return {}`
`24`	`24`	`}`
`25`	`25`