Skip to content

Add fullscreen support for MSIE, Edge and Safari#104

Merged
DeepDiver1975 merged 2 commits intomasterfrom
feature/fullscreen-msie-edge-safari
Jul 24, 2019
Merged

Add fullscreen support for MSIE, Edge and Safari#104
DeepDiver1975 merged 2 commits intomasterfrom
feature/fullscreen-msie-edge-safari

Conversation

@lordelix
Copy link
Copy Markdown
Contributor

Closes: #94

@lordelix lordelix added bug Something isn't working 3 - To review labels Jul 23, 2019
@lordelix lordelix self-assigned this Jul 23, 2019
@davitol
Copy link
Copy Markdown

davitol commented Jul 23, 2019

make dist fails

...
Running "postcss:dist" (postcss) task
>> 1 processed stylesheet created.
>> 1 sourcemap created.

Running "browserify:build" (browserify) task
>> Error: Cannot find module './geteventlisteners' from '/mnt/data/apps/files_mediaviewer/src/scripts'
Warning: Error running grunt-browserify. Use --force to continue.

Aborted due to warnings.
error Command failed with exit code 6.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Makefile:61: recipe for target 'build-js' failed
make: *** [build-js] Error 1

@felixheidecke Any clue what I'm doing wrong?

@lordelix
Copy link
Copy Markdown
Contributor Author

Aha … it's case sensitive. @davitol … fixed it.

@DeepDiver1975 DeepDiver1975 merged commit 80cba06 into master Jul 24, 2019
@delete-merged-branch delete-merged-branch Bot deleted the feature/fullscreen-msie-edge-safari branch July 24, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - To review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IE11] [Edge] [Safari] Full Screen Mode is not available for videos

3 participants