Skip to content

add QT and check playable#196

Merged
HanaGemela merged 1 commit intorelease-1.0.2from
mmattel-patch-1
Feb 28, 2020
Merged

add QT and check playable#196
HanaGemela merged 1 commit intorelease-1.0.2from
mmattel-patch-1

Conversation

@HanaGemela
Copy link
Copy Markdown
Contributor

No description provided.

@HanaGemela HanaGemela mentioned this pull request Feb 27, 2020
31 tasks
Copy link
Copy Markdown
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QT is QuickTime, here :-) -- just saying for all you Qt-people out there.

@mmattel Do we also want to add video/mpeg ?
For ogg-theora, I know that a fallback to application/ogg is used, not sure if such things should also be listed here.

@mmattel
Copy link
Copy Markdown
Contributor

mmattel commented Feb 28, 2020

We can add any mime we want as long it starts with video easily.

Yes, mpegis a good idea.

Correction: mpeg does not have it's own mimetype, pls see
https://www.iana.org/assignments/media-types/media-types.xhtml

The new code for video can be extended/changed to add more basic types.
I have build the code around a mime starting with video because the check itself should only be targeted for those kind of mimes if they are playable in the browser. The code may have to be adopted to reflect that other mimes not starting with video are checked if playable (video, audio).

@HanaGemela HanaGemela merged commit 682d7ed into release-1.0.2 Feb 28, 2020
@delete-merged-branch delete-merged-branch Bot deleted the mmattel-patch-1 branch February 28, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants