fix typo and import

Author: nirajacharya2

.drone.star

@@ -205,7 +205,7 @@ config = {
         },
         "oidc-iframe": {
             "skip": False,
-            "feature": [
+            "features": [
                 "specs/oidc/iframeTokenRenewal.spec.ts",
             ],
             "extraServerEnvironment": {
@@ -718,6 +718,7 @@ def e2eTestsOnPlaywright(ctx):
             "type": "docker",
             "name": "e2e-pw-%s" % suite,
             "workspace": web_workspace,
+            "environment": environment,
             "steps": steps,
             "depends_on": ["cache-ocis"],
             "trigger": base_trigger,

tests/e2e-playwright/playwright.config.ts

@@ -25,7 +25,7 @@ export default defineConfig({
   retries: config.retry,
 
   // Opt out of parallel tests on CI.
-  workers: process.env.CI ? 1 : undefined,
+  workers: 1,
 
   // Reporter to use
   reporter: [

tests/e2e-playwright/specs/navigation/personalSpacePagination.spec.ts

@@ -40,19 +40,20 @@ test.describe('Personal space pagination', { tag: '@predefined-users' }, () => {
     await ui.logInUser({ usersEnvironment, actorsEnvironment, stepUser: 'Alice' })
 
     // And "Alice" creates 15 folders in personal space using API
-    for (let i = 0; i < 15; i++) {
+    for (let i = 1; i <= 15; i++) {
       await api.userHasCreatedFolder({
         usersEnvironment,
         stepUser: 'Alice',
         folderName: `folder${i}`
       })
     }
     // And "Alice" creates 10 files in personal space using API
-    for (let i = 0; i < 15; i++) {
+    for (let i = 1; i <= 10; i++) {
       await api.userHasCreatedFile({
         usersEnvironment,
         stepUser: 'Alice',
-        filename: `file${i}`
+        filename: `file${i}`,
+        content: `This is a test file${i}`
       })
     }
     // And "Alice" creates the following files into personal space using API
@@ -91,7 +92,7 @@ test.describe('Personal space pagination', { tag: '@predefined-users' }, () => {
       expectedNumberOfResources: 6
     })
     // When "Alice" changes the items per page to "500"
-    await ui.changeItemsPerPage({ actorsEnvironment, stepUser: 'Alice', itemsPerPage: '20' })
+    await ui.changeItemsPerPage({ actorsEnvironment, stepUser: 'Alice', itemsPerPage: '500' })
 
     // Then "Alice" should not see the pagination in the personal space files view
     await ui.expectPageNumberNotToBeVisible({ actorsEnvironment, stepUser: 'Alice' })

tests/e2e-playwright/specs/oidc/iframeTokenRenewal.spec.ts

@@ -1,4 +1,4 @@
-import { test } from '@playwright/test'
+import { test, expect } from '@playwright/test'
 import { config } from './../../../e2e/config.js'
 import { ActorsEnvironment, UsersEnvironment } from '../../../e2e/support/environment'
 import { setAccessAndRefreshToken } from '../../helpers/setAccessAndRefreshToken'

tests/e2e-playwright/specs/oidc/refreshToken.spec.ts

@@ -27,6 +27,7 @@ test.describe('details', () => {
   })
 
   test.afterEach(async () => {
+    await setAccessAndRefreshToken(usersEnvironment)
     await api.deleteUser({ usersEnvironment, stepUser: 'Admin', targetUser: 'Alice' })
   })
 

tests/e2e-playwright/specs/spaces/createSpaceFromSelection.spec.ts

@@ -1,4 +1,4 @@
-import { test } from '@playwright/test'
+import { test, expect } from '@playwright/test'
 import { config } from './../../../e2e/config.js'
 import {
   ActorsEnvironment,
@@ -84,7 +84,7 @@ test.describe('create Space shortcut', () => {
       actorsEnvironment,
       filesEnvironment,
       stepUser: 'Alice',
-      resource: 'lorem.zip',
+      resource: 'lorem.txt',
       to: 'spaceFolder'
     })
 
@@ -141,19 +141,19 @@ test.describe('create Space shortcut', () => {
     // And "Alice" uploads the following resources
     //   | resource          | to             |
     //   | data.zip          | resourceFolder |
-    //   | lorem.txt         | spaceFolder    |
+    //   | lorem.txt         |                |
     await ui.uploadResource({
       actorsEnvironment,
       filesEnvironment,
       stepUser: 'Alice',
       resource: 'data.zip',
-      to: 'spaceFolder'
+      to: 'resourceFolder'
     })
     await ui.uploadResource({
       actorsEnvironment,
       filesEnvironment,
       stepUser: 'Alice',
-      resource: 'lorem.zip',
+      resource: 'lorem.txt',
       to: ''
     })
 

tests/e2e-playwright/specs/spaces/denySpaceAccess.spec.ts

@@ -1,4 +1,4 @@
-import { test } from '@playwright/test'
+import { test, expect } from '@playwright/test'
 import { config } from './../../../e2e/config.js'
 import {
   ActorsEnvironment,
@@ -91,7 +91,7 @@ test.describe('deny space access', () => {
     await api.userHasAddedMembersToSpace({
       usersEnvironment,
       stepUser: 'Alice',
-      space: 'team',
+      space: 'sales',
       shareType: 'user',
       sharee: 'Brian',
       role: 'Can edit'

tests/e2e-playwright/specs/spaces/downloadSpace.spec.ts

@@ -102,7 +102,7 @@ test.describe('download space', () => {
       actorsEnvironment,
       usersEnvironment,
       stepUser: 'Alice',
-      sharee: 'team.1',
+      sharee: 'Brian',
       role: 'Can edit',
       kind: 'user'
     })

tests/e2e-playwright/specs/user-settings/notifications.spec.ts

@@ -271,7 +271,7 @@ test.describe('Notifications', () => {
     //   | message                         |
     //   | %user_alice_displayName% deleted Space team |
     messages = await ui.getNotificationMessages({ actorsEnvironment, stepUser: 'Brian' })
-    expect(messages).toContain(substitute('%user_alice_displayName% delete Space team'))
+    expect(messages).toContain(substitute('%user_alice_displayName% deleted Space team'))
 
     await api.userHasDeletedGroup({ usersEnvironment, stepUser: 'Admin', name: 'sales' })
   })
@@ -298,7 +298,7 @@ test.describe('Notifications', () => {
     })
 
     // And "Brian" logs in
-    await ui.logInUser({ usersEnvironment, actorsEnvironment, stepUser: 'Alice' })
+    await ui.logInUser({ usersEnvironment, actorsEnvironment, stepUser: 'Brian' })
 
     // And "Brian" opens the user menu
     await ui.userOpensAccountPage({ actorsEnvironment, stepUser: 'Brian' })
@@ -444,7 +444,7 @@ test.describe('Notifications', () => {
     })
 
     // Then "Carol" should see no notifications
-    messages = await ui.getNotificationMessages({ actorsEnvironment, stepUser: 'Coral' })
+    messages = await ui.getNotificationMessages({ actorsEnvironment, stepUser: 'Carol' })
     expect(messages).toHaveLength(0)
   })
 })

tests/e2e-playwright/steps/api/api.ts

@@ -9,8 +9,9 @@ import { ResourceType } from '../../../e2e/support/api/share/share'
 import { Group, Space, User } from '../../../e2e/support/types'
 import fs from 'fs'
 import { integer } from 'vscode-languageserver-types'
-import join from 'join-path'
+
 import { checkResponseStatus, request } from '../../../e2e/support/api/http'
+import { join } from 'path'
 
 export async function userHasBeenCreated({
   usersEnvironment,
@@ -360,6 +361,7 @@ export async function userHasDeletedProjectSpace({
 }) {
   const user = usersEnvironment.getUser({ key: stepUser })
   await api.graph.deleteSpace({ user, space: { id, name } as unknown as Space })
+  store.createdSpaceStore.clear()
 }
 
 export async function userHasAddedMembersToSpace({