Skip to content

Commit 5ce8558

Browse files
committed
fix(linter): Add onScrollEnd and onScrollEndCapture to valid DOM properties list.
onScrollEndCapture is somewhat special and specific to React. onScrollEnd is normal JS though. https://developer.mozilla.org/en-US/docs/Web/API/Document/scrollend_event See also facebook/react#26789
1 parent fd11073 commit 5ce8558

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

crates/oxc_linter/src/rules/react/no_unknown_property.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ const DOM_PROPERTIES_NAMES: Set<&'static str> = phf_set! {
256256
"onCompositionUpdate", "onCut", "onDoubleClick", "onDrag", "onDragEnd", "onDragEnter", "onDragExit", "onDragLeave",
257257
"onError", "onFocus", "onInput", "onKeyDown", "onKeyPress", "onKeyUp", "onLoad", "onWheel", "onDragOver",
258258
"onDragStart", "onDrop", "onMouseDown", "onMouseEnter", "onMouseLeave", "onMouseMove", "onMouseOut", "onMouseOver",
259-
"onMouseUp", "onPaste", "onScroll", "onSelect", "onSubmit", "onBeforeToggle", "onToggle", "onTransitionEnd", "radioGroup",
259+
"onMouseUp", "onPaste", "onScroll", "onScrollEnd", "onSelect", "onSubmit", "onBeforeToggle", "onToggle", "onTransitionEnd", "radioGroup",
260260
"readOnly", "referrerPolicy", "rowSpan", "srcDoc", "srcLang", "srcSet", "useMap",
261261
// SVG attributes
262262
// See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute
@@ -306,7 +306,7 @@ const DOM_PROPERTIES_NAMES: Set<&'static str> = phf_set! {
306306
"onEndedCapture", "onLoadedDataCapture", "onLoadedMetadataCapture", "onLoadStartCapture", "onPauseCapture", "onPlayCapture",
307307
"onPlayingCapture", "onProgressCapture", "onRateChangeCapture", "onSeekedCapture", "onSeekingCapture", "onStalledCapture", "onSuspendCapture",
308308
"onTimeUpdateCapture", "onVolumeChangeCapture", "onWaitingCapture", "onSelectCapture", "onTouchCancelCapture", "onTouchEndCapture",
309-
"onTouchMoveCapture", "onTouchStartCapture", "onScrollCapture", "onWheelCapture", "onAnimationEndCapture",
309+
"onTouchMoveCapture", "onTouchStartCapture", "onScrollCapture", "onScrollEndCapture", "onWheelCapture", "onAnimationEndCapture",
310310
"onAnimationStartCapture", "onTransitionEndCapture",
311311
"onAuxClick", "onAuxClickCapture", "onClickCapture", "onContextMenuCapture", "onDoubleClickCapture",
312312
"onDragCapture", "onDragEndCapture", "onDragEnterCapture", "onDragExitCapture", "onDragLeaveCapture",
@@ -591,6 +591,8 @@ fn test() {
591591
(r#"<App clip-path="bar" />;"#, None),
592592
(r#"<div className="bar"></div>;"#, None),
593593
(r"<div onMouseDown={this._onMouseDown}></div>;", None),
594+
(r"<div onScrollEnd={this._onScrollEnd}></div>;", None),
595+
(r"<div onScrollEndCapture={this._onScrollEndCapture}></div>;", None),
594596
(r#"<a href="someLink" download="foo">Read more</a>"#, None),
595597
(r#"<area download="foo" />"#, None),
596598
(r#"<img src="cat_keyboard.jpeg" alt="A cat sleeping on a keyboard" align="top" />"#, None),

0 commit comments

Comments
 (0)