fix

Author: sanbir

src/adapters/aave/AaveRewardsAllowedCalldataChecker.sol

@@ -39,6 +39,15 @@ contract AaveRewardsAllowedCalldataChecker is IAllowedCalldataChecker, Initializ
 
     /// @inheritdoc IAllowedCalldataChecker
     function checkCalldata(
+        address,
+        bytes4,
+        bytes calldata
+    ) external pure {
+        revert AllowedCalldataChecker__NoAllowedCalldata();
+    }
+
+    /// @inheritdoc IAllowedCalldataChecker
+    function checkCalldataForClaimAdditionalRewardTokens(
         address _target,
         bytes4 _selector,
         bytes calldata

src/adapters/compound/CompoundRewardsAllowedCalldataChecker.sol

@@ -23,6 +23,15 @@ contract CompoundRewardsAllowedCalldataChecker is IAllowedCalldataChecker, Initi
 
     /// @inheritdoc IAllowedCalldataChecker
     function checkCalldata(
+        address,
+        bytes4,
+        bytes calldata
+    ) external pure {
+        revert AllowedCalldataChecker__NoAllowedCalldata();
+    }
+
+    /// @inheritdoc IAllowedCalldataChecker
+    function checkCalldataForClaimAdditionalRewardTokens(
         address _target,
         bytes4 _selector,
         bytes calldata

src/adapters/spark/SparkRewardsAllowedCalldataChecker.sol

@@ -41,6 +41,15 @@ contract SparkRewardsAllowedCalldataChecker is IAllowedCalldataChecker, Initiali
 
     /// @inheritdoc IAllowedCalldataChecker
     function checkCalldata(
+        address,
+        bytes4,
+        bytes calldata
+    ) external pure {
+        revert AllowedCalldataChecker__NoAllowedCalldata();
+    }
+
+    /// @inheritdoc IAllowedCalldataChecker
+    function checkCalldataForClaimAdditionalRewardTokens(
         address _target,
         bytes4 _selector,
         bytes calldata

src/common/AllowedCalldataChecker.sol

@@ -26,4 +26,13 @@ contract AllowedCalldataChecker is IAllowedCalldataChecker, Initializable {
     ) public pure {
         revert AllowedCalldataChecker__NoAllowedCalldata();
     }
+
+    /// @inheritdoc IAllowedCalldataChecker
+    function checkCalldataForClaimAdditionalRewardTokens(
+        address,
+        bytes4,
+        bytes calldata
+    ) public pure {
+        revert AllowedCalldataChecker__NoAllowedCalldata();
+    }
 }

src/common/IAllowedCalldataChecker.sol

@@ -8,7 +8,7 @@ pragma solidity 0.8.30;
 /// @notice Interface for checking if a calldata is allowed
 interface IAllowedCalldataChecker {
 
-    /// @notice Checks if the calldata is allowed
+    /// @notice Checks if the calldata is allowed for callAnyFunction / callAnyFunctionByP2pOperator
     /// @param _target The address of the yield protocol
     /// @param _selector The selector of the function
     /// @param _calldataAfterSelector The calldata after the selector
@@ -17,4 +17,14 @@ interface IAllowedCalldataChecker {
         bytes4 _selector,
         bytes calldata _calldataAfterSelector
     ) external view;
+
+    /// @notice Checks if the calldata is allowed for claimAdditionalRewardTokens
+    /// @param _target The address of the rewards contract
+    /// @param _selector The selector of the function
+    /// @param _calldataAfterSelector The calldata after the selector
+    function checkCalldataForClaimAdditionalRewardTokens(
+        address _target,
+        bytes4 _selector,
+        bytes calldata _calldataAfterSelector
+    ) external view;
 }

src/p2pYieldProxy/features/AdditionalRewardClaimer.sol

@@ -84,9 +84,9 @@ abstract contract AdditionalRewardClaimer is
 
         bytes4 selector = bytes4(_callData[:4]);
         if (msg.sender == s_client) {
-            _allowedCalldataChecker().checkCalldata(_target, selector, _callData[4:]);
+            _allowedCalldataChecker().checkCalldataForClaimAdditionalRewardTokens(_target, selector, _callData[4:]);
         } else {
-            _allowedCalldataByClientToP2pChecker().checkCalldata(_target, selector, _callData[4:]);
+            _allowedCalldataByClientToP2pChecker().checkCalldataForClaimAdditionalRewardTokens(_target, selector, _callData[4:]);
         }
 
         uint256 tokenCount = _tokens.length;

test/mock/MockAllowedCalldataChecker.sol

@@ -18,4 +18,12 @@ contract MockAllowedCalldataChecker is IAllowedCalldataChecker, Initializable {
     ) external pure {
         // allow everything
     }
+
+    function checkCalldataForClaimAdditionalRewardTokens(
+        address,
+        bytes4,
+        bytes calldata
+    ) external pure {
+        // allow everything
+    }
 }