fix: prevent camera drive when game unfocused

fixes #348

Author: Krzyhau

src/Features/Camera.cpp

@@ -95,12 +95,23 @@ float Camera::GetCurrentPathTime() {
 //if in drive mode, checks if player wants to control the camera
 //for now it requires LMB input (as in demo drive mode)
 bool Camera::IsDriving() {
+	if (!engine->IsGameFocused() || vgui->IsUIVisible()) {
+		return false;
+	}
+
+	if (camera->controlType != Drive && camera->controlType != Follow) {
+		return false;
+	}
+
+	bool userWantsToDrive = sar_cam_drive.GetInt() == 2 || inputSystem->IsKeyDown(ButtonCode_t::MOUSE_LEFT);
+	if (!userWantsToDrive) {
+		return false;
+	}
+
 	bool drivingInGame = sar_cam_drive.GetBool() && engine->hoststate->m_activeGame;
 	bool drivingInDemo = engine->demoplayer->IsPlaying();
-	bool wantingToDrive = sar_cam_drive.GetInt() == 2 || inputSystem->IsKeyDown(ButtonCode_t::MOUSE_LEFT);
-	bool isUI = vgui->IsUIVisible();
 
-	return (camera->controlType == Drive || camera->controlType == Follow) && wantingToDrive && (drivingInGame || drivingInDemo) && !isUI;
+	return drivingInGame || drivingInDemo;
 }
 
 //used by camera state interpolation function. all the math is here.

src/Modules/Engine.cpp

@@ -186,6 +186,10 @@ bool Engine::IsGamePaused() {
 	return this->IsPaused(this->engineClient->ThisPtr());
 }
 
+bool Engine::IsGameFocused() {
+	return this->IsActiveApp(this->engineClient->ThisPtr());
+}
+
 int Engine::GetMapIndex(const std::string map) {
 	std::string map_lower = map;
 	std::transform(map_lower.begin(), map_lower.end(), map_lower.begin(), tolower);
@@ -949,6 +953,7 @@ bool Engine::Init() {
 		this->GetSaveDirName = this->engineClient->Original<_GetSaveDirName>(Offsets::GetSaveDirName);
 		this->DebugDrawPhysCollide = this->engineClient->Original<_DebugDrawPhysCollide>(Offsets::DebugDrawPhysCollide);
 		this->IsPaused = this->engineClient->Original<_IsPaused>(Offsets::IsPaused);
+		this->IsActiveApp = this->engineClient->Original<_IsActiveApp>(Offsets::IsActiveApp);
 		this->Con_IsVisible = this->engineClient->Original<_Con_IsVisible>(Offsets::Con_IsVisible);
 		this->GetLevelNameShort = this->engineClient->Original<_GetLevelNameShort>(Offsets::GetLevelNameShort);
 		this->GetLightForPoint = this->engineClient->Original<_GetLightForPoint>(Offsets::GetLightForPoint);

src/Modules/Engine.hpp

@@ -44,6 +44,7 @@ class Engine : public Module {
 	using _ClientTime = float (*)(void *thisptr);
 	using _DebugDrawPhysCollide = bool(__rescall *)(void *thisptr, const void *collide, IMaterial *material, const matrix3x4_t &transform, const Color &color);
 	using _IsPaused = bool (*)(void *thisptr);
+	using _IsActiveApp = bool(*)(void *thisptr);
 	using _TraceRay = void(__rescall *)(void *thisptr, const Ray_t &ray, unsigned int fMask, ITraceFilter *pTraceFilter, CGameTrace *pTrace);
 	using _PointOutsideWorld = bool(__rescall *)(void *thisptr, const Vector &test);
 	using _GetCount = int(__rescall *)(void *thisptr);
@@ -90,6 +91,7 @@ class Engine : public Module {
 	_GetLightForPoint GetLightForPoint = nullptr;
 	_DebugDrawPhysCollide DebugDrawPhysCollide = nullptr;
 	_IsPaused IsPaused = nullptr;
+	_IsActiveApp IsActiveApp = nullptr;
 	_TraceRay TraceRay = nullptr;
 	_TraceRay TraceRayClient = nullptr;
 	_PointOutsideWorld PointOutsideWorld = nullptr;
@@ -144,6 +146,7 @@ class Engine : public Module {
 	float GetHostTime();
 	bool isRunning();
 	bool IsGamePaused();
+	bool IsGameFocused();
 	int GetMapIndex(const std::string map);
 	std::string GetCurrentMapName();
 	std::string GetMapTitle(std::string map);

src/Offsets/Portal 2 9568.hpp

@@ -34,6 +34,7 @@ OFFSET_DEFAULT(GetSaveDirName, 124, 124)
 OFFSET_DEFAULT(ExecuteClientCmd, 104, 104)
 OFFSET_DEFAULT(GetActiveSplitScreenPlayerSlot, 127, 127)
 OFFSET_DEFAULT(GetSteamAPIContext, 177, 178)
+OFFSET_DEFAULT(IsActiveApp, 187, 188)
 OFFSET_DEFAULT(GetMouseDelta, -1, 161)  // This method only exists on Linux
 OFFSET_DEFAULT(IsPaused, 86, 86)
 OFFSET_DEFAULT(DebugDrawPhysCollide, 75, 75)