Skip to content

Commit 4bd32f2

Browse files
ronamidevongovett
authored andcommitted
close hmr server when HMRServer.stop() is called (#1079)
1 parent 8a95f70 commit 4bd32f2

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/HMRServer.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,16 @@ const logger = require('./Logger');
99
class HMRServer {
1010
async start(options = {}) {
1111
await new Promise(async resolve => {
12-
let server;
1312
if (!options.https) {
14-
server = http.createServer();
13+
this.server = http.createServer();
1514
} else if (typeof options.https === 'boolean') {
16-
server = https.createServer(generateCertificate(options));
15+
this.server = https.createServer(generateCertificate(options));
1716
} else {
18-
server = https.createServer(await getCertificate(options.https));
17+
this.server = https.createServer(await getCertificate(options.https));
1918
}
2019

21-
this.wss = new WebSocket.Server({server});
22-
server.listen(options.hmrPort, resolve);
20+
this.wss = new WebSocket.Server({server: this.server});
21+
this.server.listen(options.hmrPort, resolve);
2322
});
2423

2524
this.wss.on('connection', ws => {
@@ -36,6 +35,7 @@ class HMRServer {
3635

3736
stop() {
3837
this.wss.close();
38+
this.server.close();
3939
}
4040

4141
emitError(err) {

0 commit comments

Comments
 (0)