add support for data attr of object element (#1069)

gnijuohz · devongovett · commit 6e8ae0d97c8b · 2018-03-27T21:39:57.000-07:00
diff --git a/src/assets/HTMLAsset.js b/src/assets/HTMLAsset.js
@@ -24,7 +24,8 @@ const ATTRS = {
   srcset: ['img', 'source'],
   poster: ['video'],
   'xlink:href': ['use'],
-  content: ['meta']
+  content: ['meta'],
+  data: ['object']
 };
 
 // A list of metadata that should produce a dependency
diff --git a/test/html.js b/test/html.js
@@ -534,4 +534,20 @@ describe('html', function() {
       ]
     });
   });
+
+  it('should support data attribute of object element', async function() {
+    let b = await bundle(__dirname + '/integration/html-object/index.html');
+
+    assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'svg',
+          assets: ['file.svg'],
+          childBundles: []
+        }
+      ]
+    });
+  });
 });
diff --git a/test/integration/html-object/file.svg b/test/integration/html-object/file.svg
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" id="all">
+    <rect width="100" height="100" x="0" y="0"/>
+</svg>
diff --git a/test/integration/html-object/index.html b/test/integration/html-object/index.html
@@ -0,0 +1,2 @@
+<!DOCTYPE html>
+<object data="file.svg" type="image/svg+xml"></object>

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+<!DOCTYPE html>`
	`2`	`+<object data="file.svg" type="image/svg+xml"></object>`