Remove eval usage. Fixes CSP cases. (#1133)

Author: cvx

src/builtins/hmr-runtime.js

@@ -1,6 +1,5 @@
 var OVERLAY_ID = '__parcel__error__overlay__';
 
-var global = (1, eval)('this');
 var OldModule = module.bundle.Module;
 
 function Module(moduleName) {

src/builtins/prelude.js

@@ -45,7 +45,7 @@ parcelRequire = (function (modules, cache, entry, globalName) {
 
       var module = cache[name] = new newRequire.Module(name);
 
-      modules[name][0].call(module.exports, localRequire, module, module.exports);
+      modules[name][0].call(module.exports, localRequire, module, module.exports, this);
     }
 
     return cache[name].exports;

src/visitors/globals.js

@@ -7,7 +7,7 @@ const VARS = {
     asset.addDependency('process');
     return 'var process = require("process");';
   },
-  global: () => 'var global = (1,eval)("this");',
+  global: () => 'var global = arguments[3];',
   __dirname: asset =>
     `var __dirname = ${JSON.stringify(Path.dirname(asset.name))};`,
   __filename: asset => `var __filename = ${JSON.stringify(asset.name)};`,

test/integration/global-redeclare/index.js

@@ -0,0 +1,4 @@
+const global = {};
+module.exports = function () {
+  return !!global.document;
+};

test/integration/global-redeclare/package.json

@@ -0,0 +1,5 @@
+{
+  "name": "parcel-test-global-redeclare",
+  "private": true,
+  "browserslist": ["last 2 Chrome versions"]
+}

test/javascript.js

@@ -376,6 +376,13 @@ describe('javascript', function() {
     });
   });
 
+  it('should handle re-declaration of the global constant', async function() {
+    let b = await bundle(__dirname + '/integration/global-redeclare/index.js');
+
+    let output = run(b);
+    assert.deepEqual(output(), false);
+  });
+
   it('should insert environment variables', async function() {
     let b = await bundle(__dirname + '/integration/env/index.js');