Refactor prettifySize (#883)

Glinkis · devongovett · commit f897bf72819e · 2018-02-23T22:27:48.000-08:00
Untangles if/else in favor of returns.
diff --git a/src/utils/bundleReport.js b/src/utils/bundleReport.js
@@ -80,12 +80,9 @@ function* iterateBundles(bundle) {
 function prettifySize(size, isLarge) {
   let res = filesize(size);
   if (isLarge) {
-    res = logger.chalk.yellow(emoji.warning + '  ' + res);
-  } else {
-    res = logger.chalk.magenta(res);
+    return logger.chalk.yellow(emoji.warning + '  ' + res);
   }
-
-  return res;
+  return logger.chalk.magenta(res);
 }
 
 function formatFilename(filename, color = logger.chalk.reset) {

Original file line number	Diff line number	Diff line change
`@@ -80,12 +80,9 @@ function* iterateBundles(bundle) {`
`80`	`80`	`function prettifySize(size, isLarge) {`
`81`	`81`	`let res = filesize(size);`
`82`	`82`	`if (isLarge) {`
`83`		`- res = logger.chalk.yellow(emoji.warning + ' ' + res);`
`84`		`- } else {`
`85`		`- res = logger.chalk.magenta(res);`
	`83`	`+ return logger.chalk.yellow(emoji.warning + ' ' + res);`
`86`	`84`	`}`
`87`		`-`
`88`		`- return res;`
	`85`	`+ return logger.chalk.magenta(res);`
`89`	`86`	`}`
`90`	`87`
`91`	`88`	`function formatFilename(filename, color = logger.chalk.reset) {`