fix #10149 (comment)

Author: mtrezza

spec/AuthDataUniqueIndex.spec.js

@@ -137,26 +137,19 @@ describe('AuthData Unique Index', () => {
     config.database.options.databaseOptions = originalOptions;
   });
 
-  it('should handle calling ensureAuthDataUniqueness multiple times via cache', async () => {
+  it('should handle calling ensureAuthDataUniqueness multiple times (idempotent)', async () => {
     const config = Config.get('test');
     const adapter = config.database.adapter;
 
-    // First call creates the index
+    // Both calls should succeed (index creation is idempotent)
     await adapter.ensureAuthDataUniqueness('fakeAuthProvider');
-    // Second call should be a cache hit (no DB call)
     await adapter.ensureAuthDataUniqueness('fakeAuthProvider');
-    expect(adapter._authDataUniqueIndexes.has('fakeAuthProvider')).toBe(true);
   });
 
   it('should log warning when index creation fails due to existing duplicates', async () => {
     const config = Config.get('test');
     const adapter = config.database.adapter;
 
-    // Clear cache to force index creation attempt
-    if (adapter._authDataUniqueIndexes) {
-      adapter._authDataUniqueIndexes.clear();
-    }
-
     // Spy on the adapter to simulate a duplicate value error
     spyOn(adapter, 'ensureAuthDataUniqueness').and.callFake(() => {
       return Promise.reject(

src/Adapters/Storage/Mongo/MongoStorageAdapter.js

@@ -844,22 +844,13 @@ export class MongoStorageAdapter implements StorageAdapter {
   // Creates a unique sparse index on _auth_data_<provider>.id to prevent
   // race conditions during concurrent signups with the same authData.
   ensureAuthDataUniqueness(provider: string) {
-    if (!this._authDataUniqueIndexes) {
-      this._authDataUniqueIndexes = new Set();
-    }
-    if (this._authDataUniqueIndexes.has(provider)) {
-      return Promise.resolve();
-    }
     return this._adaptiveCollection('_User')
       .then(collection =>
         collection._mongoCollection.createIndex(
           { [`_auth_data_${provider}.id`]: 1 },
           { unique: true, sparse: true, background: true, name: `_auth_data_${provider}_id` }
         )
       )
-      .then(() => {
-        this._authDataUniqueIndexes.add(provider);
-      })
       .catch(error => {
         if (error.code === 11000) {
           throw new Parse.Error(
@@ -869,7 +860,6 @@ export class MongoStorageAdapter implements StorageAdapter {
         }
         // Ignore "index already exists with same name" or "index already exists with different options"
         if (error.code === 85 || error.code === 86) {
-          this._authDataUniqueIndexes.add(provider);
           return;
         }
         throw error;

src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

@@ -1223,9 +1223,6 @@ export class PostgresStorageAdapter implements StorageAdapter {
     const now = new Date().getTime();
     const helpers = this._pgp.helpers;
     debug('deleteAllClasses');
-    if (this._authDataUniqueIndexes) {
-      this._authDataUniqueIndexes.clear();
-    }
     if (this._client?.$pool.ended) {
       return;
     }
@@ -2087,12 +2084,6 @@ export class PostgresStorageAdapter implements StorageAdapter {
   // Creates a unique index on authData-><provider>->>'id' to prevent
   // race conditions during concurrent signups with the same authData.
   async ensureAuthDataUniqueness(provider: string) {
-    if (!this._authDataUniqueIndexes) {
-      this._authDataUniqueIndexes = new Set();
-    }
-    if (this._authDataUniqueIndexes.has(provider)) {
-      return;
-    }
     const indexName = `_User_unique_authData_${provider}_id`;
     const qs = `CREATE UNIQUE INDEX IF NOT EXISTS $1:name ON "_User" (("authData"->$2::text->>'id')) WHERE "authData"->$2::text->>'id' IS NOT NULL`;
     await this._client.none(qs, [indexName, provider]).catch(error => {
@@ -2113,7 +2104,6 @@ export class PostgresStorageAdapter implements StorageAdapter {
         throw error;
       }
     });
-    this._authDataUniqueIndexes.add(provider);
   }
 
   // Executes a count.