fix: Account lockout race condition allows bypassing threshold via concurrent requests (#10266)

Author: mtrezza

spec/AccountLockoutPolicy.spec.js

@@ -341,6 +341,56 @@ describe('Account Lockout Policy: ', () => {
         done();
       });
   });
+
+  it('should enforce lockout threshold under concurrent failed login attempts', async () => {
+    const threshold = 3;
+    await reconfigureServer({
+      appName: 'lockout race',
+      accountLockout: {
+        duration: 5,
+        threshold,
+      },
+      publicServerURL: 'http://localhost:8378/1',
+    });
+
+    const user = new Parse.User();
+    user.setUsername('race_user');
+    user.setPassword('correct_password');
+    await user.signUp();
+
+    const concurrency = 30;
+    const results = await Promise.all(
+      Array.from({ length: concurrency }, () =>
+        request({
+          method: 'POST',
+          url: 'http://localhost:8378/1/login',
+          headers: {
+            'X-Parse-Application-Id': 'test',
+            'X-Parse-REST-API-Key': 'rest',
+            'Content-Type': 'application/json',
+          },
+          body: JSON.stringify({ username: 'race_user', password: 'wrong_password' }),
+        }).catch(err => err)
+      )
+    );
+
+    const lockoutError =
+      'Your account is locked due to multiple failed login attempts. Please try again after 5 minute(s)';
+    const errors = results.map(r => {
+      const body = typeof r.data === 'string' ? JSON.parse(r.data) : r.data;
+      return body?.error;
+    });
+    const invalidPassword = errors.filter(error => error === 'Invalid username/password.');
+    const lockoutResponses = errors.filter(error => error === lockoutError);
+
+    expect(
+      errors.every(
+        error => error === 'Invalid username/password.' || error === lockoutError
+      )
+    ).toBeTrue();
+    expect(lockoutResponses.length).toBeGreaterThan(0);
+    expect(invalidPassword.length).toBeLessThanOrEqual(threshold);
+  });
 });
 
 describe('lockout with password reset option', () => {

src/AccountLockout.js

@@ -23,37 +23,7 @@ export class AccountLockout {
   }
 
   /**
-   * check if the _failed_login_count field has been set
-   */
-  _isFailedLoginCountSet() {
-    const query = {
-      username: this._user.username,
-      _failed_login_count: { $exists: true },
-    };
-
-    return this._config.database.find('_User', query).then(users => {
-      if (Array.isArray(users) && users.length > 0) {
-        return true;
-      } else {
-        return false;
-      }
-    });
-  }
-
-  /**
-   * if _failed_login_count is NOT set then set it to 0
-   * else do nothing
-   */
-  _initFailedLoginCount() {
-    return this._isFailedLoginCountSet().then(failedLoginCountIsSet => {
-      if (!failedLoginCountIsSet) {
-        return this._setFailedLoginCount(0);
-      }
-    });
-  }
-
-  /**
-   * increment _failed_login_count by 1
+   * increment _failed_login_count by 1 and return the updated document
    */
   _incrementFailedLoginCount() {
     const query = {
@@ -127,20 +97,26 @@ export class AccountLockout {
   }
 
   /**
-   * set and/or increment _failed_login_count
-   * if _failed_login_count > threshold
-   *   set the _account_lockout_expires_at to current_time + accountPolicy.duration
-   * else
-   *   do nothing
+   * Atomically increment _failed_login_count and enforce lockout threshold.
+   * Uses the atomic increment result to determine the exact post-increment
+   * count, eliminating the TOCTOU race between checking and updating.
    */
   _handleFailedLoginAttempt() {
-    return this._initFailedLoginCount()
-      .then(() => {
-        return this._incrementFailedLoginCount();
-      })
-      .then(() => {
-        return this._setLockoutExpiration();
-      });
+    return this._incrementFailedLoginCount().then(result => {
+      const count = result._failed_login_count;
+      if (count >= this._config.accountLockout.threshold) {
+        return this._setLockoutExpiration().then(() => {
+          if (count > this._config.accountLockout.threshold) {
+            throw new Parse.Error(
+              Parse.Error.OBJECT_NOT_FOUND,
+              'Your account is locked due to multiple failed login attempts. Please try again after ' +
+                this._config.accountLockout.duration +
+                ' minute(s)'
+            );
+          }
+        });
+      }
+    });
   }
 
   /**