fix: Buffer constructor throwing "Unsafe Promise species cannot be reset" (#558)

Author: patriksimek

lib/setup-sandbox.js

@@ -317,14 +317,14 @@ class BufferHandler extends ReadOnlyHandler {
 		if (args.length > 0 && typeof args[0] === 'number') {
 			return LocalBuffer.alloc(args[0]);
 		}
-		return localReflectApply(LocalBuffer.from, LocalBuffer, args);
+		return apply(LocalBuffer.from, LocalBuffer, args);
 	}
 
 	construct(target, args, newTarget) {
 		if (args.length > 0 && typeof args[0] === 'number') {
 			return LocalBuffer.alloc(args[0]);
 		}
-		return localReflectApply(LocalBuffer.from, LocalBuffer, args);
+		return apply(LocalBuffer.from, LocalBuffer, args);
 	}
 }
 /* eslint-enable no-use-before-define */

test/vm.js

@@ -322,6 +322,20 @@ describe('contextify', () => {
 		assert.ok(d.constructor.constructor === Function);
 	});
 
+	it('buffer (deprecated constructor)', () => {
+		const result = vm.run('new Buffer("Hello")');
+		assert.ok(result instanceof Buffer, '#1');
+		assert.strictEqual(result.toString(), 'Hello', '#2');
+
+		const result2 = vm.run('new Buffer(5)');
+		assert.ok(result2 instanceof Buffer, '#3');
+		assert.strictEqual(result2.length, 5, '#4');
+
+		const result3 = vm.run('Buffer("Hello")');
+		assert.ok(result3 instanceof Buffer, '#5');
+		assert.strictEqual(result3.toString(), 'Hello', '#6');
+	});
+
 	it('function', () => {
 		assert.strictEqual(vm.run('test.function instanceof Function'), true, '#1');
 		assert.strictEqual(vm.run('test.function() instanceof Function'), true, '#2');