Merge pull request #70 from missinglink/ring_closed

ring: require >=4 points to return true when calling Closed()

Author: paulmach

ring.go

@@ -17,8 +17,7 @@ func (r Ring) Dimensions() int {
 // ie. 4+ points and the first and last points match.
 // NOTE: this will not check for self-intersection.
 func (r Ring) Closed() bool {
-	// first must equal last
-	return r[0] == r[len(r)-1]
+	return (len(r) >= 4) && (r[0] == r[len(r)-1])
 }
 
 // Reverse changes the direction of the ring.

ring_test.go

@@ -17,13 +17,28 @@ func TestRing_Closed(t *testing.T) {
 		},
 		{
 			name:   "not closed if last point does not match",
-			ring:   Ring{{0, 0}, {3, 0}, {3, 4}},
+			ring:   Ring{{0, 0}, {3, 0}, {3, 3}, {3, 4}},
 			closed: false,
 		},
 		{
-			name:   "length of ring doesn't matter",
+			name:   "empty ring",
+			ring:   Ring{},
+			closed: false,
+		},
+		{
+			name:   "one vertex ring",
+			ring:   Ring{{3, 0}},
+			closed: false,
+		},
+		{
+			name:   "two vertex ring",
 			ring:   Ring{{3, 0}, {3, 0}},
-			closed: true,
+			closed: false,
+		},
+		{
+			name:   "three vertex ring",
+			ring:   Ring{{3, 0}, {0, 0}, {3, 0}},
+			closed: false,
 		},
 	}