feat: add pr-title check and pre-commit action#29
Merged
Conversation
chomatdam
approved these changes
Aug 13, 2024
Contributor
|
forgot to mention there is a duplicate with |
Contributor
|
Thanks @josmo for the fix and the tips I confirm that it is now working well both local and CI ! Also did a follow-up PR to remove duplicated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #26 for the CI run of pre-commit
For local I think you need to run
pre-commit install --hook-type commit-msgto enforce the pre-commit message check