Skip to content

fix: removed duplicated config for pre-commit#30

Merged
scoquelin merged 1 commit intomainfrom
remove-dup-pre-commit
Aug 14, 2024
Merged

fix: removed duplicated config for pre-commit#30
scoquelin merged 1 commit intomainfrom
remove-dup-pre-commit

Conversation

@scoquelin
Copy link
Copy Markdown
Contributor

Follow-up PR to remove duplicated pre-commit configs

@scoquelin
Copy link
Copy Markdown
Contributor Author

Actually spoke too soon the CI is still not showing the commitlint validation, will try to fix it

@josmo
Copy link
Copy Markdown
Member

josmo commented Aug 14, 2024

Well crap. I'll take a gander when I get a chance too :) thanks

@scoquelin scoquelin force-pushed the remove-dup-pre-commit branch 2 times, most recently from 507bc4a to 578dfc8 Compare August 14, 2024 00:39
@scoquelin
Copy link
Copy Markdown
Contributor Author

There is a complete explanation here :

alessandrojcm/commitlint-pre-commit-hook#53

but not sure if we want to take that route

@scoquelin scoquelin merged commit e9d08b8 into main Aug 14, 2024
@scoquelin scoquelin deleted the remove-dup-pre-commit branch August 14, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants