feat(selectors): Extract selectors from daemonsets if not provided through config#33
Merged
feat(selectors): Extract selectors from daemonsets if not provided through config#33
Conversation
scoquelin
changed the title
scoquelin
changed the title
scoquelin
changed the title
scoquelin
changed the title
scoquelin
changed the title
scoquelin
force-pushed
the
match-daemonset-selector
branch
2 times, most recently
from
1f724ad to
ac5366e
Compare
scoquelin
requested review from
chomatdam and
josmo
and removed request for
chomatdam
scoquelin
force-pushed
the
match-daemonset-selector
branch
from
d600e17 to
4ded6d1
Compare
scoquelin
force-pushed
the
match-daemonset-selector
branch
from
4ded6d1 to
a8fb012
Compare
scoquelin
force-pushed
the
match-daemonset-selector
branch
from
a8fb012 to
19cbff1
Compare
Contributor
Author
|
@josmo @chomatdam I would appreciate some feedback on this PR thanks ! |
josmo
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to retrieve selectors directly from the daemon sets when
NodeSelectorhas not been provided in config.However, when
NodeSelectoris provided through config, it will take precedence over retrieving selectors from daemon sets directly.calculateTaintsto remove previous logic based oncontinueCloses #1