feat: adding ratelimiting parameters#74
Merged
josmo merged 5 commits intopelotech:mainfrom May 28, 2025
Merged
Conversation
Member
|
@kevin90n thanks a ton for the contribution and sorry it's taken a sec to look at this. We'll take a look in the next few days |
Contributor
|
LGTM, just a whitespace before |
Contributor
Author
|
@chomatdam Thanks for the review! I have updated the PR now with the requested changes. |
chomatdam
approved these changes
May 26, 2025
Contributor
Author
|
@chomatdam @josmo Can this PR be already merged or we need more approvals? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya Pelotech peeps!
Firstly, I would like to highlight how useful this project is! Thank you for maintaining it!
We have recently discovered some client request throttling in our Kubernetes API servers. To mitigate that, we were looking for ways to introduce rate limiting for system addons.
This PR introduces extraArgs for statefulset to enable kubernetes API rate limiting parameters.
Please let me know if there is anything I can add to improve this PR