Looks like GitHub didn't run... curious. We ought to run this on a large test set before including this on a release.

Using pyquil (previously tested with this package), the changes on this pull request make no difference:

$ git checkout v2.19.0
$ flake8 --select RST --rst-roles ref,py:class,py:func --rst-directives versionadded pyquil/
pyquil/gates.py:0:1: RST902 Failed to parse __all__ entry.
pyquil/simulation/matrices.py:0:1: RST902 Failed to parse __all__ entry.
pyquil/simulation/tools.py:177:1: RST301 Unexpected indentation.
pyquil/simulation/tools.py:178:1: RST201 Block quote ends without a blank line; unexpected unindent.
pyquil/simulation/tests/test_numpy.py:276:1: RST213 Inline emphasis start-string without end-string.
pyquil/simulation/tests/test_numpy.py:280:1: RST213 Inline emphasis start-string without end-string.
pyquil/api/_quantum_computer.py:928:1: RST303 Unknown directive type "deprecated".
pyquil/experiment/_program.py:52:1: RST214 Inline literal start-string without end-string.
pyquil/experiment/_program.py:52:1: RST214 Inline literal start-string without end-string

Interesting case in https://github.com/rigetti/pyquil/blob/v2.19.0/pyquil/simulation/tests/test_numpy.py#L273 which has one naughty *args in the free text (which deserves a warning and can be fixed), but in the arg list has *matrices (which the hack does not allow for).

def kron(*matrices: np.ndarray) -> np.ndarray:
    """Computes the kronecker product of a sequence of matrices.
    A *args version of lambda args: functools.reduce(np.kron, args).
    Args:
        *matrices: The matrices and controls to combine with the kronecker
            product.
    Returns:
        The resulting matrix.
    """
    ....

Could potentially inspect the function definition to decide which starred variable names to check for and thus ignore *matrices here.

Similar in astropy, plenty of examples where the variable names are not *args and **kwargs although some cases are class level parameter documentation (so would have to look ahead to the __init__ to see the expected parameter names). Perhaps any variable name should be accepted (simpler solution).

This needs a little refactoring now... rebasing.

CodeClimate is rightly critical of the style of this fix.