Skip to content

Commit 0677414

Browse files
aboseabose
committed
chore: add more design mode supported commands
1 parent 5d7264c commit 0677414

22 files changed

Lines changed: 85 additions & 85 deletions

File tree

‎src/command/KeyboardOverlayMode.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ define(function (require, exports, module) {
203203

204204
AppInit.appReady(function () {
205205
CommandManager.register(Strings.CMD_KEYBOARD_NAV_OVERLAY,
206-
Commands.CMD_KEYBOARD_NAV_UI_OVERLAY, startOverlayMode);
206+
Commands.CMD_KEYBOARD_NAV_UI_OVERLAY, startOverlayMode, { supportsDesignMode: true });
207207
const viewMenu = Menus.getMenu(Menus.AppMenuBar.VIEW_MENU);
208208
viewMenu.addMenuItem(Commands.CMD_KEYBOARD_NAV_UI_OVERLAY, 'Ctrl-P',
209209
Menus.AFTER, Commands.VIEW_TOGGLE_INSPECTION);

‎src/document/DocumentCommandHandlers.js‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2414,7 +2414,7 @@ define(function (require, exports, module) {
24142414
CommandManager.register(Strings.CMD_FILE_OPEN, Commands.FILE_OPEN, handleDocumentOpen, _designModeOpts);
24152415

24162416
// New commands
2417-
CommandManager.register(Strings.CMD_ADD_TO_WORKING_SET, Commands.CMD_ADD_TO_WORKINGSET_AND_OPEN, handleFileAddToWorkingSetAndOpen);
2417+
CommandManager.register(Strings.CMD_ADD_TO_WORKING_SET, Commands.CMD_ADD_TO_WORKINGSET_AND_OPEN, handleFileAddToWorkingSetAndOpen, _designModeOpts);
24182418
CommandManager.register(Strings.CMD_FILE_OPEN, Commands.CMD_OPEN, handleFileOpen, _designModeOpts);
24192419

24202420
// File Commands
@@ -2423,33 +2423,33 @@ define(function (require, exports, module) {
24232423
CommandManager.register(Strings.CMD_FILE_NEW_FOLDER, Commands.FILE_NEW_FOLDER, handleNewFolderInProject);
24242424
CommandManager.register(Strings.CMD_FILE_SAVE, Commands.FILE_SAVE, handleFileSave, _designModeOpts);
24252425
CommandManager.register(Strings.CMD_FILE_SAVE_ALL, Commands.FILE_SAVE_ALL, handleFileSaveAll, _designModeOpts);
2426-
CommandManager.register(Strings.CMD_FILE_SAVE_AS, Commands.FILE_SAVE_AS, handleFileSaveAs);
2426+
CommandManager.register(Strings.CMD_FILE_SAVE_AS, Commands.FILE_SAVE_AS, handleFileSaveAs, _designModeOpts);
24272427
CommandManager.register(Strings.CMD_FILE_RENAME, Commands.FILE_RENAME, handleFileRename);
24282428
CommandManager.register(Strings.CMD_FILE_DELETE, Commands.FILE_DELETE, handleFileDelete);
24292429

24302430
// Close Commands
24312431
CommandManager.register(Strings.CMD_FILE_CLOSE, Commands.FILE_CLOSE, handleFileClose, _designModeOpts);
24322432
CommandManager.register(Strings.CMD_FILE_CLOSE_ALL, Commands.FILE_CLOSE_ALL, handleFileCloseAll, _designModeOpts);
2433-
CommandManager.register(Strings.CMD_FILE_CLOSE_LIST, Commands.FILE_CLOSE_LIST, handleFileCloseList);
2433+
CommandManager.register(Strings.CMD_FILE_CLOSE_LIST, Commands.FILE_CLOSE_LIST, handleFileCloseList, _designModeOpts);
24342434
CommandManager.register(Strings.CMD_REOPEN_CLOSED, Commands.FILE_REOPEN_CLOSED, handleReopenClosed, _designModeOpts);
24352435

24362436
// Traversal
2437-
CommandManager.register(Strings.CMD_NEXT_DOC, Commands.NAVIGATE_NEXT_DOC, handleGoNextDoc);
2438-
CommandManager.register(Strings.CMD_PREV_DOC, Commands.NAVIGATE_PREV_DOC, handleGoPrevDoc);
2437+
CommandManager.register(Strings.CMD_NEXT_DOC, Commands.NAVIGATE_NEXT_DOC, handleGoNextDoc, _designModeOpts);
2438+
CommandManager.register(Strings.CMD_PREV_DOC, Commands.NAVIGATE_PREV_DOC, handleGoPrevDoc, _designModeOpts);
24392439

2440-
CommandManager.register(Strings.CMD_NEXT_DOC_LIST_ORDER, Commands.NAVIGATE_NEXT_DOC_LIST_ORDER, handleGoNextDocListOrder);
2441-
CommandManager.register(Strings.CMD_PREV_DOC_LIST_ORDER, Commands.NAVIGATE_PREV_DOC_LIST_ORDER, handleGoPrevDocListOrder);
2440+
CommandManager.register(Strings.CMD_NEXT_DOC_LIST_ORDER, Commands.NAVIGATE_NEXT_DOC_LIST_ORDER, handleGoNextDocListOrder, _designModeOpts);
2441+
CommandManager.register(Strings.CMD_PREV_DOC_LIST_ORDER, Commands.NAVIGATE_PREV_DOC_LIST_ORDER, handleGoPrevDocListOrder, _designModeOpts);
24422442

24432443
// Special Commands
2444-
CommandManager.register(showInOS, Commands.NAVIGATE_SHOW_IN_OS, handleShowInOS);
2445-
CommandManager.register(defaultTerminal, Commands.NAVIGATE_OPEN_IN_TERMINAL, openDefaultTerminal);
2444+
CommandManager.register(showInOS, Commands.NAVIGATE_SHOW_IN_OS, handleShowInOS, _designModeOpts);
2445+
CommandManager.register(defaultTerminal, Commands.NAVIGATE_OPEN_IN_TERMINAL, openDefaultTerminal, _designModeOpts);
24462446
if (brackets.platform === "win") {
24472447
CommandManager.register(Strings.CMD_OPEN_IN_POWER_SHELL, Commands.NAVIGATE_OPEN_IN_POWERSHELL, openPowerShell);
24482448
}
2449-
CommandManager.register(Strings.CMD_OPEN_IN_DEFAULT_APP, Commands.NAVIGATE_OPEN_IN_DEFAULT_APP, openDefaultApp);
2449+
CommandManager.register(Strings.CMD_OPEN_IN_DEFAULT_APP, Commands.NAVIGATE_OPEN_IN_DEFAULT_APP, openDefaultApp, _designModeOpts);
24502450
CommandManager.register(Strings.CMD_NEW_BRACKETS_WINDOW, Commands.FILE_NEW_WINDOW, handleFileNewWindow, _designModeOpts);
2451-
CommandManager.register(quitString, Commands.FILE_QUIT, handleFileCloseWindow);
2452-
CommandManager.register(Strings.CMD_SHOW_IN_TREE, Commands.NAVIGATE_SHOW_IN_FILE_TREE, handleShowInTree);
2451+
CommandManager.register(quitString, Commands.FILE_QUIT, handleFileCloseWindow, _designModeOpts);
2452+
CommandManager.register(Strings.CMD_SHOW_IN_TREE, Commands.NAVIGATE_SHOW_IN_FILE_TREE, handleShowInTree, _designModeOpts);
24532453

24542454
// These commands have no UI representation and are only used internally
24552455
CommandManager.registerInternal(Commands.APP_ABORT_QUIT, handleAbortQuit);

‎src/extensibility/ExtensionManagerDialog.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ define(function (require, exports, module) {
429429
return new $.Deferred().resolve(dialog).promise();
430430
}
431431

432-
CommandManager.register(Strings.CMD_EXTENSION_MANAGER, Commands.FILE_EXTENSION_MANAGER, _showDialog);
432+
CommandManager.register(Strings.CMD_EXTENSION_MANAGER, Commands.FILE_EXTENSION_MANAGER, _showDialog, { supportsDesignMode: true });
433433

434434
AppInit.appReady(function () {
435435
$("#toolbar-extension-manager").click(_showDialog);

‎src/extensions/default/CloseOthers/main.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,13 +157,13 @@ define(function (require, exports, module) {
157157

158158
CommandManager.register(Strings.CMD_FILE_CLOSE_BELOW, closeBelow, function () {
159159
handleClose(closeBelow);
160-
});
160+
}, { supportsDesignMode: true });
161161
CommandManager.register(Strings.CMD_FILE_CLOSE_OTHERS, closeOthers, function () {
162162
handleClose(closeOthers);
163-
});
163+
}, { supportsDesignMode: true });
164164
CommandManager.register(Strings.CMD_FILE_CLOSE_ABOVE, closeAbove, function () {
165165
handleClose(closeAbove);
166-
});
166+
}, { supportsDesignMode: true });
167167

168168
if (prefs.closeBelow) {
169169
workingSetListCmenu.addMenuItem(closeBelow, "", Menus.AFTER, Commands.FILE_CLOSE);

‎src/extensions/default/DebugCommands/main.js‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -776,30 +776,30 @@ define(function (require, exports, module) {
776776
let loadOrReloadString = extensionDevelopment.isProjectLoadedAsExtension() ?
777777
Strings.CMD_RELOAD_CURRENT_EXTENSION : Strings.CMD_LOAD_CURRENT_EXTENSION;
778778
CommandManager.register(loadOrReloadString, DEBUG_LOAD_CURRENT_EXTENSION,
779-
extensionDevelopment.loadCurrentExtension);
779+
extensionDevelopment.loadCurrentExtension, { supportsDesignMode: true });
780780
CommandManager.register(Strings.CMD_UNLOAD_CURRENT_EXTENSION, DEBUG_UNLOAD_CURRENT_EXTENSION,
781-
extensionDevelopment.unloadCurrentExtension);
782-
CommandManager.register(Strings.CMD_REFRESH_WINDOW, DEBUG_REFRESH_WINDOW, handleReload);
783-
CommandManager.register(Strings.CMD_RELOAD_WITHOUT_USER_EXTS, DEBUG_RELOAD_WITHOUT_USER_EXTS, handleReloadWithoutUserExts);
781+
extensionDevelopment.unloadCurrentExtension, { supportsDesignMode: true });
782+
CommandManager.register(Strings.CMD_REFRESH_WINDOW, DEBUG_REFRESH_WINDOW, handleReload, { supportsDesignMode: true });
783+
CommandManager.register(Strings.CMD_RELOAD_WITHOUT_USER_EXTS, DEBUG_RELOAD_WITHOUT_USER_EXTS, handleReloadWithoutUserExts, { supportsDesignMode: true });
784784

785785
// Start with the "Run Tests" item disabled. It will be enabled later if the test file can be found.
786-
CommandManager.register(Strings.CMD_RUN_UNIT_TESTS, DEBUG_RUN_UNIT_TESTS, _runUnitTests);
786+
CommandManager.register(Strings.CMD_RUN_UNIT_TESTS, DEBUG_RUN_UNIT_TESTS, _runUnitTests, { supportsDesignMode: true });
787787

788-
CommandManager.register(Strings.CMD_SHOW_PERF_DATA, DEBUG_SHOW_PERF_DATA, handleShowPerfData);
788+
CommandManager.register(Strings.CMD_SHOW_PERF_DATA, DEBUG_SHOW_PERF_DATA, handleShowPerfData, { supportsDesignMode: true });
789789

790790
let switchLanguageStr = Strings.CMD_SWITCH_LANGUAGE === "Switch Language\u2026" ?
791791
Strings.CMD_SWITCH_LANGUAGE :
792792
`${Strings.CMD_SWITCH_LANGUAGE} (Switch Language)`;
793-
CommandManager.register(switchLanguageStr, DEBUG_SWITCH_LANGUAGE, handleSwitchLanguage);
793+
CommandManager.register(switchLanguageStr, DEBUG_SWITCH_LANGUAGE, handleSwitchLanguage, { supportsDesignMode: true });
794794

795-
CommandManager.register(Strings.CMD_ENABLE_LOGGING, DEBUG_ENABLE_LOGGING, _handleLogging);
796-
CommandManager.register(Strings.CMD_ENABLE_PHNODE_INSPECTOR, DEBUG_ENABLE_PHNODE_INSPECTOR, _handlePhNodeInspectEnable);
797-
CommandManager.register(Strings.CMD_GET_PHNODE_INSPECTOR_URL, DEBUG_GET_PHNODE_INSPECTOR_URL, _handleGetPhNodeInspectURL);
798-
CommandManager.register(Strings.CMD_ENABLE_LIVE_PREVIEW_LOGS, DEBUG_LIVE_PREVIEW_LOGGING, _handleLivePreviewLogging);
799-
CommandManager.register(Strings.CMD_ENABLE_GIT_LOGS, DEBUG_GIT_EXTENSION_LOGGING, _handleGitLogging);
800-
CommandManager.register(Strings.CMD_OPEN_VFS, DEBUG_OPEN_VFS, _openVFS);
801-
CommandManager.register(Strings.CMD_OPEN_EXTENSIONS_FOLDER, DEBUG_OPEN_EXTENSION_FOLDER, _openExtensionsFolder);
802-
CommandManager.register(Strings.CMD_OPEN_VIRTUAL_SERVER, DEBUG_OPEN_VIRTUAL_SERVER, _openVirtualServer);
795+
CommandManager.register(Strings.CMD_ENABLE_LOGGING, DEBUG_ENABLE_LOGGING, _handleLogging, { supportsDesignMode: true });
796+
CommandManager.register(Strings.CMD_ENABLE_PHNODE_INSPECTOR, DEBUG_ENABLE_PHNODE_INSPECTOR, _handlePhNodeInspectEnable, { supportsDesignMode: true });
797+
CommandManager.register(Strings.CMD_GET_PHNODE_INSPECTOR_URL, DEBUG_GET_PHNODE_INSPECTOR_URL, _handleGetPhNodeInspectURL, { supportsDesignMode: true });
798+
CommandManager.register(Strings.CMD_ENABLE_LIVE_PREVIEW_LOGS, DEBUG_LIVE_PREVIEW_LOGGING, _handleLivePreviewLogging, { supportsDesignMode: true });
799+
CommandManager.register(Strings.CMD_ENABLE_GIT_LOGS, DEBUG_GIT_EXTENSION_LOGGING, _handleGitLogging, { supportsDesignMode: true });
800+
CommandManager.register(Strings.CMD_OPEN_VFS, DEBUG_OPEN_VFS, _openVFS, { supportsDesignMode: true });
801+
CommandManager.register(Strings.CMD_OPEN_EXTENSIONS_FOLDER, DEBUG_OPEN_EXTENSION_FOLDER, _openExtensionsFolder, { supportsDesignMode: true });
802+
CommandManager.register(Strings.CMD_OPEN_VIRTUAL_SERVER, DEBUG_OPEN_VIRTUAL_SERVER, _openVirtualServer, { supportsDesignMode: true });
803803

804804
CommandManager.register(Strings.CMD_OPEN_PREFERENCES, DEBUG_OPEN_PREFERENCES_IN_SPLIT_VIEW, handleOpenPrefsInSplitView);
805805
const debugMenu = Menus.getMenu(Menus.AppMenuBar.DEBUG_MENU);
@@ -815,7 +815,7 @@ define(function (require, exports, module) {
815815
debugMenu.addMenuDivider();
816816
// Show Developer Tools (optionally enabled)
817817
if(Phoenix.isNativeApp){
818-
CommandManager.register(Strings.CMD_SHOW_DEV_TOOLS, DEBUG_SHOW_DEVELOPER_TOOLS, _handleShowDeveloperTools);
818+
CommandManager.register(Strings.CMD_SHOW_DEV_TOOLS, DEBUG_SHOW_DEVELOPER_TOOLS, _handleShowDeveloperTools, { supportsDesignMode: true });
819819
debugMenu.addMenuItem(DEBUG_SHOW_DEVELOPER_TOOLS, KeyboardPrefs.showDeveloperTools);
820820
}
821821
// this command is defined in core, but exposed only in Debug menu for now
@@ -826,7 +826,7 @@ define(function (require, exports, module) {
826826
}
827827
const diagnosticsSubmenu = debugMenu.addSubMenu(Strings.CMD_DIAGNOSTIC_TOOLS, DIAGNOSTICS_SUBMENU);
828828
diagnosticsSubmenu.addMenuItem(DEBUG_RUN_UNIT_TESTS);
829-
CommandManager.register(Strings.CMD_BUILD_TESTS, DEBUG_BUILD_TESTS, TestBuilder.toggleTestBuilder);
829+
CommandManager.register(Strings.CMD_BUILD_TESTS, DEBUG_BUILD_TESTS, TestBuilder.toggleTestBuilder, { supportsDesignMode: true });
830830
diagnosticsSubmenu.addMenuItem(DEBUG_BUILD_TESTS);
831831
if (AppConfig.config.environment === "dev") {
832832
diagnosticsSubmenu.addMenuItem("debug.phoenixBuilderConnect");

‎src/extensions/default/Git/src/CloseNotModified.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ define(function (require, exports) {
4848

4949
function init() {
5050
closeUnmodifiedCmd = CommandManager.register(Strings.CMD_CLOSE_UNMODIFIED,
51-
Constants.CMD_GIT_CLOSE_UNMODIFIED, handleCloseNotModified);
51+
Constants.CMD_GIT_CLOSE_UNMODIFIED, handleCloseNotModified, { supportsDesignMode: true });
5252
Utils.enableCommand(Constants.CMD_GIT_CLOSE_UNMODIFIED, false);
5353
}
5454

‎src/extensions/default/HealthData/main.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ define(function (require, exports, module) {
4343

4444
// Register the command and add the menu item for the Health Data Statistics
4545
function addCommand() {
46-
CommandManager.register(Strings.CMD_HEALTH_DATA_STATISTICS, healthDataCmdId, handleHealthDataStatistics);
46+
CommandManager.register(Strings.CMD_HEALTH_DATA_STATISTICS, healthDataCmdId, handleHealthDataStatistics, { supportsDesignMode: true });
4747

4848
menu.addMenuItem(healthDataCmdId, "", Menus.AFTER, Commands.HELP_GET_INVOLVED);
4949
menu.addMenuDivider(Menus.AFTER, Commands.HELP_GET_INVOLVED);

‎src/extensions/default/Phoenix-extension-store/main.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ define(function (require, exports, module) {
8686

8787
ExtensionUtils.loadStyleSheet(module, "extension-store.css");
8888
// todo: replace with extension manager dialogue command
89-
toggleCmd = CommandManager.register("Extensions Panel", "toggleExtensionsPanel", _toggleVisibility);
89+
toggleCmd = CommandManager.register("Extensions Panel", "toggleExtensionsPanel", _toggleVisibility, { supportsDesignMode: true });
9090

9191
function _createExtensionPanel() {
9292
$icon = $("#toolbar-extension-manager");

‎src/extensionsIntegrated/DisplayShortcuts/main.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
/*global define, brackets, $, CodeMirror, _showShortcuts, window */
2525

2626
define(function (require, exports, module) {
27-
27+
2828
// Brackets modules
2929
const _ = require("thirdparty/lodash"),
3030
CodeMirror = require("thirdparty/CodeMirror/lib/codemirror"),
@@ -111,7 +111,7 @@ define(function (require, exports, module) {
111111
function _getOriginFromCommandId(cmdID, keyBinding) {
112112
// According to CommandManager.register() documentation:
113113
// Core commands in Brackets use a simple command title as an id, for example "open.file".
114-
// Extensions should use the following format: "author.myextension.mycommandname".
114+
// Extensions should use the following format: "author.myextension.mycommandname".
115115
// For example, "lschmitt.csswizard.format.css".
116116
const customOrigin = KeyBindingManager._getCustomShortcutOrigin(keyBinding);
117117
if(customOrigin){
@@ -303,7 +303,7 @@ define(function (require, exports, module) {
303303
// New sort column
304304
sortColumn = newSortColumn;
305305
}
306-
306+
307307
// Update page
308308
_showShortcuts();
309309
}
@@ -341,7 +341,7 @@ define(function (require, exports, module) {
341341
function _showShortcuts() {
342342
_updatePresets();
343343
let $shortcuts = $("#shortcuts-panel");
344-
344+
345345
// Apply any active filter
346346
_filterShortcuts(true);
347347

@@ -465,7 +465,7 @@ define(function (require, exports, module) {
465465
let s, file_menu;
466466

467467
// Register commands
468-
CommandManager.register(Strings.KEYBOARD_SHORTCUT_MENU_SHOW_SHORTCUTS, TOGGLE_SHORTCUTS_ID, _handleShowHideShortcuts);
468+
CommandManager.register(Strings.KEYBOARD_SHORTCUT_MENU_SHOW_SHORTCUTS, TOGGLE_SHORTCUTS_ID, _handleShowHideShortcuts, { supportsDesignMode: true });
469469

470470
// Add command to Help menu, if it exists
471471
file_menu = Menus.getMenu(Menus.AppMenuBar.FILE_MENU);

‎src/extensionsIntegrated/NavigationAndHistory/NavigationProvider.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -538,8 +538,8 @@ define(function (require, exports, module) {
538538
* @private
539539
*/
540540
function _initNavigationCommands() {
541-
CommandManager.register(Strings.CMD_NAVIGATE_BACKWARD, NAVIGATION_JUMP_BACK, _navigateBack);
542-
CommandManager.register(Strings.CMD_NAVIGATE_FORWARD, NAVIGATION_JUMP_FWD, _navigateForward);
541+
CommandManager.register(Strings.CMD_NAVIGATE_BACKWARD, NAVIGATION_JUMP_BACK, _navigateBack, { supportsDesignMode: true });
542+
CommandManager.register(Strings.CMD_NAVIGATE_FORWARD, NAVIGATION_JUMP_FWD, _navigateForward, { supportsDesignMode: true });
543543
if(Phoenix.isTestWindow){
544544
CommandManager.register("reset nav forward and back for tests", _NAVIGATION_RESET_FOR_TESTS, _clearStacks);
545545
}

0 commit comments

Comments
 (0)
⚡