Commit 1fdcf51
committed
test(nav): stop new click-dispatch tests from leaking state into the suite
Two changes to the new click-dispatch tests added in fa455de:
- #showInfileTree test no longer opens test.css. recordCommands hooks
EVENT_BEFORE_EXECUTE_COMMAND, which fires whether or not handleShowInTree's
activeFile branch runs, so the openFile call added nothing to the assertion
but did leak a test.css entry into session-restore state, shifting the
nav-history ordering that _validateNavForFiles("test.css", ...) expects.
- #searchNav test now closes the Find-in-Files bar via FindInFilesUI._closeFindBar
and awaits .modal-bar removal before returning. Leaving the modal open
caused full-suite runs to fail subsequent navigation tests with
"Active file to be test.css timed out" because the stale modal bar's
focus/key handling persisted across closeTestWindow + loadProjectInTestWindow.
Nav suite passes 6/6 in isolation across three consecutive runs.1 parent 6dd641c commit 1fdcf51
1 file changed
Lines changed: 18 additions & 3 deletions
File tree
- test/spec
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
356 | 356 | | |
357 | 357 | | |
358 | 358 | | |
359 | | - | |
360 | | - | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
361 | 364 | | |
362 | 365 | | |
363 | 366 | | |
| |||
366 | 369 | | |
367 | 370 | | |
368 | 371 | | |
369 | | - | |
| 372 | + | |
370 | 373 | | |
371 | 374 | | |
372 | 375 | | |
373 | 376 | | |
374 | 377 | | |
375 | 378 | | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
376 | 391 | | |
377 | 392 | | |
378 | 393 | | |
| |||
0 commit comments