feat: bottom panel doesnt open with the tab last closed

Author: devvaannsh

src/view/DefaultPanelView.js

@@ -198,13 +198,18 @@ define(function (require, exports, module) {
             }
         });
 
-        // Update drawer button state based on bottom panel container visibility.
-        // The app drawer icon stays selected whenever the bottom panel is visible.
+        // Drawer button reflects whether the Quick Access (default) panel is
+        // the active visible panel. _switchToTab silently swaps active tabs
+        // without firing PANEL_HIDDEN for the previous one, so we have to gate
+        // the SHOWN handler on the panelID — relying on a HIDDEN event would
+        // miss the case where another tab takes over from Quick Access.
+        // The minimize-button "stuck selected" case is handled by PanelView
+        // firing PANEL_HIDDEN with the default panel id, picked up below.
         PanelView.on(PanelView.EVENT_PANEL_SHOWN, function (event, panelID) {
             if (panelID === WorkspaceManager.DEFAULT_PANEL_ID) {
                 _updateButtonVisibility();
             }
-            $drawerBtn.addClass("selected-button");
+            $drawerBtn.toggleClass("selected-button", panelID === WorkspaceManager.DEFAULT_PANEL_ID);
         });
 
         PanelView.on(PanelView.EVENT_PANEL_HIDDEN, function (event, panelID) {

src/view/PanelView.js

@@ -908,23 +908,12 @@ define(function (require, exports, module) {
             _showOverflowMenu();
         });
 
-        // Hide-panel button collapses the container but keeps tabs intact.
-        // Maximize state is preserved so the panel re-opens maximized.
+        // Hide-panel button collapses the container but keeps the active
+        // panel logically active so re-opening (drawer / Escape) restores it
+        // with its content already mounted.
         _$tabBar.on("click", ".bottom-panel-hide-btn", function (e) {
             e.stopPropagation();
-            if (_$container && _$container.is(":visible")) {
-                if (_activeId) {
-                    const activePanel = _panelMap[_activeId];
-                    if (activePanel) {
-                        activePanel.$panel.removeClass("active-bottom-panel");
-                    }
-                }
-                _activeId = null;
-                _updateActiveTabHighlight();
-                restoreIfMaximized();
-                Resizer.hide(_$container[0]);
-                exports.trigger(EVENT_PANEL_HIDDEN, _defaultPanelId);
-            }
+            collapseContainer();
         });
 
         // Maximize/restore toggle button
@@ -1132,6 +1121,39 @@ define(function (require, exports, module) {
         return _isMaximized;
     }
 
+    /**
+     * Collapse the bottom panel container (transient hide) without touching
+     * which panel is logically active. Fires EVENT_PANEL_HIDDEN with the
+     * default panel id as a "container collapsed" signal so toolbar icons
+     * and menu items that mirror container visibility deselect.
+     * No-op if the container is already hidden.
+     */
+    function collapseContainer() {
+        if (!_$container || !_$container.is(":visible")) {
+            return;
+        }
+        restoreIfMaximized();
+        Resizer.hide(_$container[0]);
+        exports.trigger(EVENT_PANEL_HIDDEN, _defaultPanelId);
+    }
+
+    /**
+     * Re-show the bottom panel container after a previous collapse, with the
+     * previously active panel still mounted. Fires EVENT_PANEL_SHOWN for the
+     * active panel id so toolbar icons / menu items that mirror visibility
+     * re-select. No-op if the container is already visible or there's no
+     * active panel to restore.
+     */
+    function restoreContainer() {
+        if (!_$container || _$container.is(":visible")) {
+            return;
+        }
+        Resizer.show(_$container[0]);
+        if (_activeId) {
+            exports.trigger(EVENT_PANEL_SHOWN, _activeId);
+        }
+    }
+
     /**
      * Returns a copy of the currently open bottom panel IDs in tab order.
      * @return {string[]}
@@ -1226,6 +1248,8 @@ define(function (require, exports, module) {
     exports.restoreIfMaximized = restoreIfMaximized;
     exports.isMaximized = isMaximized;
     exports.MAXIMIZE_THRESHOLD = MAXIMIZE_THRESHOLD;
+    exports.collapseContainer = collapseContainer;
+    exports.restoreContainer = restoreContainer;
     //events
     exports.EVENT_PANEL_HIDDEN = EVENT_PANEL_HIDDEN;
     exports.EVENT_PANEL_SHOWN = EVENT_PANEL_SHOWN;

src/view/WorkspaceManager.js

@@ -812,9 +812,14 @@ define(function (require, exports, module) {
             return false;
         }
         if ($bottomPanelContainer.is(":visible")) {
-            Resizer.hide($bottomPanelContainer[0]);
+            // Use the helper so HIDDEN(_defaultPanelId) fires — toolbar
+            // buttons and menu items that mirror container visibility
+            // (drawer, Git icon, etc.) need this signal to deselect.
+            PanelView.collapseContainer();
         } else if (PanelView.getOpenBottomPanelIDs().length > 0) {
-            Resizer.show($bottomPanelContainer[0]);
+            // Use the helper so SHOWN(_activeId) fires — same listeners
+            // need this signal to re-select after a previous collapse.
+            PanelView.restoreContainer();
         } else {
             _showDefaultPanel();
         }