Skip to content

Commit 14d2c3d

Browse files
authored
Merge pull request #135 from phyloref/fix_phyloreference_superclass
Setting `phyloref:Phyloreference` to the superclass of all phyloreferences messed something up in JPhyloRef, which now won't reason over them correctly. This ought to be a priority, but since we're going to replace this entire model with phyloref/phyloref-ontology#29 pretty soon, I'm just going to revert it for now and then overhaul the entire model later.
2 parents 4256e49 + c34f360 commit 14d2c3d

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

js/phyx.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,10 +1205,11 @@ class PhylorefWrapper {
12051205
// Set the @id and @type.
12061206
phylorefAsJSONLD['@id'] = phylorefURI;
12071207

1208-
// These classes are phyloreferences, and so should be classified as such.
1209-
phylorefAsJSONLD['rdfs:subClassOf'] = 'phyloref:Phyloreference';
1210-
12111208
phylorefAsJSONLD['@type'] = [
1209+
// We pun this as an instance that is a Phyloreference.
1210+
// (We need this to ensure that the object properties that store
1211+
// information on specifiers will work correctly)
1212+
'phyloref:Phyloreference',
12121213
// Since we're writing this in RDF, just adding a '@type' of
12131214
// phyloref:Phyloreference would imply that phylorefURI is a named
12141215
// individual of class phyloref:Phyloreference. We need to explicitly

0 commit comments

Comments
 (0)