relay: address comment

csuzhangxc · csuzhangxc · commit c6baaabfd39e · 2019-09-03T14:37:34.000+08:00
diff --git a/relay/relay.go b/relay/relay.go
@@ -258,9 +258,11 @@ func (r *Relay) process(parentCtx context.Context) error {
 		return err
 	}
 	defer func() {
-		err = reader2.Close()
-		if err != nil {
-			r.tctx.L().Error("fail to close binlog event reader", zap.Error(err))
+		if reader2 != nil {
+			err = reader2.Close()
+			if err != nil {
+				r.tctx.L().Error("fail to close binlog event reader", zap.Error(err))
+			}
 		}
 	}()
 

Original file line number	Diff line number	Diff line change
`@@ -258,9 +258,11 @@ func (r *Relay) process(parentCtx context.Context) error {`
`258`	`258`	`return err`
`259`	`259`	`}`
`260`	`260`	`defer func() {`
`261`		`- err = reader2.Close()`
`262`		`- if err != nil {`
`263`		`- r.tctx.L().Error("fail to close binlog event reader", zap.Error(err))`
	`261`	`+ if reader2 != nil {`
	`262`	`+ err = reader2.Close()`
	`263`	`+ if err != nil {`
	`264`	`+ r.tctx.L().Error("fail to close binlog event reader", zap.Error(err))`
	`265`	`+ }`
`264`	`266`	`}`
`265`	`267`	`}()`
`266`	`268`